infra/bots/compile_skia.isolate - Issue 1703663002: Port Skia recipe to normal Python scripts, move to Skia repo

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: infra/bots/compile_skia.isolate

Issue 1703663002: Port Skia recipe to normal Python scripts, move to Skia repo (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Move everything into infra/bots, fix readme, fix presubmit Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 {
	rmistry 2016/02/18 15:29:21 [For later] Putting isolate files and the top leve [For later] Putting isolate files and the top level scripts under bots/ is probably ok for now. If it gets to be a lot we might want to look into creating subdirs. borenet 2016/02/18 15:40:56 I suspect we'll only have four: skia_repo.isolate Show quoted text On 2016/02/18 15:29:21, rmistry wrote: > [For later] Putting isolate files and the top level scripts under bots/ is > probably ok for now. If it gets to be a lot we might want to look into creating > subdirs. I suspect we'll only have four: skia_repo.isolate compile_skia.isolate test_skia.isolate perf_skia.isolate But yes, if we end up having more, let's create an isolates directory.
	2 'includes': [

	3 'skia_repo.isolate',

	4 ],

	5 'variables': {

	6 'command': [

	7 'python', 'compile_skia.py', '<(BUILDER_NAME)', '${ISOLATED_OUTDIR}/out',

	8 ],

	9 },

	10 }

OLD	NEW