Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1703603002: Workaround for bug in Tegra 3 when uploading to a render target (Closed)

Created:
4 years, 10 months ago by bsalomon
Modified:
4 years, 10 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : whitespace #

Total comments: 2

Patch Set 3 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M include/gpu/GrCaps.h View 2 chunks +5 lines, -0 lines 0 comments Download
M src/gpu/GrCaps.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrGpu.cpp View 1 chunk +7 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
bsalomon
This fixes the failing CopySurface test on the N7
4 years, 10 months ago (2016-02-16 18:29:06 UTC) #3
robertphillips
lgtm https://codereview.chromium.org/1703603002/diff/20001/src/gpu/gl/GrGLCaps.cpp File src/gpu/gl/GrGLCaps.cpp (right): https://codereview.chromium.org/1703603002/diff/20001/src/gpu/gl/GrGLCaps.cpp#newcode459 src/gpu/gl/GrGLCaps.cpp:459: if (kTegra3_GrGLRenderer == ctxInfo.renderer()) { // comment ?
4 years, 10 months ago (2016-02-16 19:00:44 UTC) #4
bsalomon
https://codereview.chromium.org/1703603002/diff/20001/src/gpu/gl/GrGLCaps.cpp File src/gpu/gl/GrGLCaps.cpp (right): https://codereview.chromium.org/1703603002/diff/20001/src/gpu/gl/GrGLCaps.cpp#newcode459 src/gpu/gl/GrGLCaps.cpp:459: if (kTegra3_GrGLRenderer == ctxInfo.renderer()) { On 2016/02/16 19:00:44, robertphillips ...
4 years, 10 months ago (2016-02-16 19:03:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1703603002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1703603002/40001
4 years, 10 months ago (2016-02-16 19:03:11 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 19:36:50 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/babafcc681de86801b15b4fe0ab856ce32048ff6

Powered by Google App Engine
This is Rietveld 408576698