Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 17036: Build file change for enabling dynamic font support. This should go in right... (Closed)

Created:
11 years, 11 months ago by jungshik at Google
Modified:
9 years, 7 months ago
Reviewers:
eroman
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Build file change for enabling dynamic font support. This is a follow-up to the third_party/Webkit change ( http://codereview.chromium.org/16494). Update Webkit to 7592 in DEPS BUG=1303 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7594

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M chrome/app/chrome.dll.deps View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/build/WebCore/SConscript View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/build/WebCore/WebCore.vcproj View 1 chunk +8 lines, -0 lines 0 comments Download
M webkit/build/webkit_common_includes.vsprops View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/layout_tests/test_lists/tests_fixable.txt View 1 chunk +5 lines, -6 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
jungshik at Google
Updated test_fixable.list.
11 years, 11 months ago (2009-01-06 01:28:19 UTC) #1
eroman
11 years, 11 months ago (2009-01-06 02:53:52 UTC) #2
LGTM

http://codereview.chromium.org/17036/diff/205/210
File webkit/tools/layout_tests/test_lists/tests_fixable.txt (right):

http://codereview.chromium.org/17036/diff/205/210#newcode314
Line 314: // Bug: 1058654 (internal), 1303 (external)
nit: I would avoid the wording "internal" vs "external" since it sounds
exclusive. Can the "internal" bug be collapsed into crbug.com ?

Powered by Google App Engine
This is Rietveld 408576698