Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issue 1703553002: [qcms] Provide an API to compute xyY gamut area relative to NTSC 1953 (Closed)

Created:
4 years, 10 months ago by radu.velea
Modified:
4 years, 10 months ago
Reviewers:
Noel Gordon
CC:
chromium-reviews, Justin Novosad
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[qcms] Provide an API to compute xyY gamut area relative to NTSC 1953 The new API computes profile relative gamut area using (x,y) coordinates. This feature will allow a better understanding of the nature of display color profiles in use. This patch contains a test case that displays the new metric for an input profile and QCMS's internal sRGB profile. qcms_tests -t qcms_test_ntsc_gamut -i AdobeRGB.icc NTSC 1953 relative gamut area test Input profile Description: Adobe RGB (1998) NTSC relative gamut area: 92.714 % Internal reference profile Description: sRGB IEC61966-2.1 NTSC relative gamut area: 68.946 % BUG=582870 Committed: https://crrev.com/21e4879ba61638c2b96b77458feb827a7a75563a Cr-Commit-Position: refs/heads/master@{#375864}

Patch Set 1 #

Total comments: 18

Patch Set 2 : Removed whitespace and variable rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -3 lines) Patch
M third_party/qcms/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/qcms/README.chromium View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/qcms/qcms.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/qcms/src/qcms.h View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/qcms/src/qcms_util.c View 1 1 chunk +69 lines, -0 lines 0 comments Download
M third_party/qcms/src/tests/Makefile View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/qcms/src/tests/qcms_test_main.c View 2 chunks +3 lines, -1 line 0 comments Download
A third_party/qcms/src/tests/qcms_test_ntsc_gamut.c View 1 1 chunk +74 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
Noel Gordon
LGTM. Nice work, Radu. A few minor nits only. Please fix all of them, and ...
4 years, 10 months ago (2016-02-17 10:42:25 UTC) #6
Noel Gordon
+justin as an FYI, add API to tell us what the size of a color ...
4 years, 10 months ago (2016-02-17 11:20:29 UTC) #7
Noel Gordon
Also @radu, please update the bug with the relevant decisions we had to make to ...
4 years, 10 months ago (2016-02-17 11:23:07 UTC) #8
radu.velea
https://codereview.chromium.org/1703553002/diff/1/third_party/qcms/src/qcms_util.c File third_party/qcms/src/qcms_util.c (right): https://codereview.chromium.org/1703553002/diff/1/third_party/qcms/src/qcms_util.c#newcode1 third_party/qcms/src/qcms_util.c:1: // Copyright 2015 The Chromium Authors. All rights reserved. ...
4 years, 10 months ago (2016-02-17 11:31:00 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1703553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1703553002/20001
4 years, 10 months ago (2016-02-17 11:43:41 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-17 12:43:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1703553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1703553002/20001
4 years, 10 months ago (2016-02-17 12:49:07 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-17 12:54:16 UTC) #18
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 12:55:16 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/21e4879ba61638c2b96b77458feb827a7a75563a
Cr-Commit-Position: refs/heads/master@{#375864}

Powered by Google App Engine
This is Rietveld 408576698