[qcms] Provide an API to compute xyY gamut area relative to NTSC 1953

[qcms] Provide an API to compute xyY gamut area relative to NTSC 1953

The new API computes profile relative gamut area using (x,y) coordinates.
This feature will allow a better understanding of the nature of display
color profiles in use.

This patch contains a test case that displays the new metric for an
input profile and QCMS's internal sRGB profile.

qcms_tests -t qcms_test_ntsc_gamut -i AdobeRGB.icc
NTSC 1953 relative gamut area test
Input profile
	Description: Adobe RGB (1998)
	NTSC relative gamut area: 92.714 %
Internal reference profile
	Description: sRGB IEC61966-2.1
	NTSC relative gamut area: 68.946 %

BUG=582870
Committed: https://crrev.com/21e4879ba61638c2b96b77458feb827a7a75563a
Cr-Commit-Position: refs/heads/master@{#375864}

[radu.velea, 2016-02-16 15:44:43]

Description was changed from

==========
[qcms] Provide an API to compute xyY gamut area relative to NTSC 1953

BUG=582870
==========

to

==========
[qcms] Provide an API to compute xyY gamut area relative to NTSC 1953

The new API computes profile relative gamut area using (x,y) coordinates. 
This feature will allow a better understanding on the nature of display 
color profiles in use. 

BUG=582870
==========

[radu.velea, 2016-02-16 15:44:43]

radu.velea@intel.com changed reviewers:
+ noel@chromium.org

[radu.velea, 2016-02-16 15:47:37]

Description was changed from

==========
[qcms] Provide an API to compute xyY gamut area relative to NTSC 1953

The new API computes profile relative gamut area using (x,y) coordinates. 
This feature will allow a better understanding on the nature of display 
color profiles in use. 

BUG=582870
==========

to

==========
[qcms] Provide an API to compute xyY gamut area relative to NTSC 1953

The new API computes profile relative gamut area using (x,y) coordinates. 
This feature will allow a better understanding of the nature of display 
color profiles in use.

This patch contains a test case that displays the new metric for an
input profile and QCMS's internal sRGB profile.

out/Release/qcms_tests -t qcms_test_ntsc_gamut -i ~/help/AdobeRGB.icc 
NTSC 1953 relative gamut area test
Input profile
	Description: Adobe RGB (1998)
	NTSC relative gamut area: 92.714 %
Internal reference profile
	Description: sRGB IEC61966-2.1
	NTSC relative gamut area: 68.946 %

BUG=582870
==========

[radu.velea, 2016-02-16 15:47:55]

Description was changed from

==========
[qcms] Provide an API to compute xyY gamut area relative to NTSC 1953

The new API computes profile relative gamut area using (x,y) coordinates. 
This feature will allow a better understanding of the nature of display 
color profiles in use.

This patch contains a test case that displays the new metric for an
input profile and QCMS's internal sRGB profile.

out/Release/qcms_tests -t qcms_test_ntsc_gamut -i ~/help/AdobeRGB.icc 
NTSC 1953 relative gamut area test
Input profile
	Description: Adobe RGB (1998)
	NTSC relative gamut area: 92.714 %
Internal reference profile
	Description: sRGB IEC61966-2.1
	NTSC relative gamut area: 68.946 %

BUG=582870
==========

to

==========
[qcms] Provide an API to compute xyY gamut area relative to NTSC 1953

The new API computes profile relative gamut area using (x,y) coordinates. 
This feature will allow a better understanding of the nature of display 
color profiles in use.

This patch contains a test case that displays the new metric for an
input profile and QCMS's internal sRGB profile.

qcms_tests -t qcms_test_ntsc_gamut -i ~/help/AdobeRGB.icc 
NTSC 1953 relative gamut area test
Input profile
	Description: Adobe RGB (1998)
	NTSC relative gamut area: 92.714 %
Internal reference profile
	Description: sRGB IEC61966-2.1
	NTSC relative gamut area: 68.946 %

BUG=582870
==========

[radu.velea, 2016-02-16 15:48:15]

Description was changed from

==========
[qcms] Provide an API to compute xyY gamut area relative to NTSC 1953

The new API computes profile relative gamut area using (x,y) coordinates. 
This feature will allow a better understanding of the nature of display 
color profiles in use.

This patch contains a test case that displays the new metric for an
input profile and QCMS's internal sRGB profile.

qcms_tests -t qcms_test_ntsc_gamut -i ~/help/AdobeRGB.icc 
NTSC 1953 relative gamut area test
Input profile
	Description: Adobe RGB (1998)
	NTSC relative gamut area: 92.714 %
Internal reference profile
	Description: sRGB IEC61966-2.1
	NTSC relative gamut area: 68.946 %

BUG=582870
==========

to

==========
[qcms] Provide an API to compute xyY gamut area relative to NTSC 1953

The new API computes profile relative gamut area using (x,y) coordinates. 
This feature will allow a better understanding of the nature of display 
color profiles in use.

This patch contains a test case that displays the new metric for an
input profile and QCMS's internal sRGB profile.

qcms_tests -t qcms_test_ntsc_gamut -i AdobeRGB.icc 
NTSC 1953 relative gamut area test
Input profile
	Description: Adobe RGB (1998)
	NTSC relative gamut area: 92.714 %
Internal reference profile
	Description: sRGB IEC61966-2.1
	NTSC relative gamut area: 68.946 %

BUG=582870
==========

[Noel Gordon, 2016-02-17 10:42:25]

LGTM.  Nice work, Radu.  A few minor nits only.  Please fix all of them, and
then go ahead and submit.

https://codereview.chromium.org/1703553002/diff/1/third_party/qcms/src/qcms_u...
File third_party/qcms/src/qcms_util.c (right):

https://codereview.chromium.org/1703553002/diff/1/third_party/qcms/src/qcms_u...
third_party/qcms/src/qcms_util.c:1: // Copyright 2015 The Chromium Authors. All
rights reserved.
Nit: 2015 -> 2016.

https://codereview.chromium.org/1703553002/diff/1/third_party/qcms/src/qcms_u...
third_party/qcms/src/qcms_util.c:23:
s15Fixed16Number_to_float(profile->redColorant.Y) +
Make the s15Fixed16Number_to_float line-up.

 float sumRed = s15Fixed16Number_to_float(profile->redColorant.X) + 
                s15Fixed16Number_to_float(profile->redColorant.Y) +
                s15Fixed16Number_to_float(...

Same for the sumBlue & sumGreen expressions.

https://codereview.chromium.org/1703553002/diff/1/third_party/qcms/src/qcms_u...
third_party/qcms/src/qcms_util.c:41: 
Remove this blank line.

https://codereview.chromium.org/1703553002/diff/1/third_party/qcms/src/qcms_u...
third_party/qcms/src/qcms_util.c:53: float A = fabs((xRed - xBlue) * (yGreen -
yBlue) - (xGreen - xBlue) * (yRed - yBlue)) / 2;
nit: Space before this line.

Also, A -> area.

float area = fabs((xRed - xBlue) * (yGreen ...
return area;

https://codereview.chromium.org/1703553002/diff/1/third_party/qcms/src/qcms_u...
third_party/qcms/src/qcms_util.c:60: float A = get_triangle_area(candidate);
nit: A -> area.

https://codereview.chromium.org/1703553002/diff/1/third_party/qcms/src/qcms_u...
third_party/qcms/src/qcms_util.c:66: qcms_triangle triangle =
get_profile_triangle(profile);
nit: alignment / spacing.

Compare with this alignment of the get_ntsc_gamut_metric_area(), for example.  

Simple fix: make the alignment in this function consistent with the other
changes in this file.

https://codereview.chromium.org/1703553002/diff/1/third_party/qcms/src/tests/...
File third_party/qcms/src/tests/qcms_test_ntsc_gamut.c (right):

https://codereview.chromium.org/1703553002/diff/1/third_party/qcms/src/tests/...
third_party/qcms/src/tests/qcms_test_ntsc_gamut.c:1: // Copyright 2015 The
Chromium Authors. All rights reserved.
nit: 2015 -> 2016.

https://codereview.chromium.org/1703553002/diff/1/third_party/qcms/src/tests/...
third_party/qcms/src/tests/qcms_test_ntsc_gamut.c:28: if (input_path == NULL) {
if (!input_path)

https://codereview.chromium.org/1703553002/diff/1/third_party/qcms/src/tests/...
third_party/qcms/src/tests/qcms_test_ntsc_gamut.c:44: else if
(!(transform->transform_flags & TRANSFORM_FLAG_MATRIX)) {
nite: space before this line and then write it as ...

if (!(transform->transform_flags & TRANSFORM_FLAG_MATRIX)) {

[Noel Gordon, 2016-02-17 11:20:29]

+justin as an FYI, add API to tell us what the size of a color profile gamut, so
we might be able to measure what screen gamut size chrome users have.

[Noel Gordon, 2016-02-17 11:23:07]

Also @radu, please update the bug with the relevant decisions we had to make to
arrive at this approach (there were many).

[radu.velea, 2016-02-17 11:31:00]

https://codereview.chromium.org/1703553002/diff/1/third_party/qcms/src/qcms_u...
File third_party/qcms/src/qcms_util.c (right):

https://codereview.chromium.org/1703553002/diff/1/third_party/qcms/src/qcms_u...
third_party/qcms/src/qcms_util.c:1: // Copyright 2015 The Chromium Authors. All
rights reserved.
On 2016/02/17 10:42:24, noel gordon wrote:
> Nit: 2015 -> 2016.

Done.

https://codereview.chromium.org/1703553002/diff/1/third_party/qcms/src/qcms_u...
third_party/qcms/src/qcms_util.c:23:
s15Fixed16Number_to_float(profile->redColorant.Y) +
On 2016/02/17 10:42:24, noel gordon wrote:
> Make the s15Fixed16Number_to_float line-up.
> 
>  float sumRed = s15Fixed16Number_to_float(profile->redColorant.X) + 
>                 s15Fixed16Number_to_float(profile->redColorant.Y) +
>                 s15Fixed16Number_to_float(...
> 
> Same for the sumBlue & sumGreen expressions.

Done.

https://codereview.chromium.org/1703553002/diff/1/third_party/qcms/src/qcms_u...
third_party/qcms/src/qcms_util.c:41: 
On 2016/02/17 10:42:24, noel gordon wrote:
> Remove this blank line.

Done.

https://codereview.chromium.org/1703553002/diff/1/third_party/qcms/src/qcms_u...
third_party/qcms/src/qcms_util.c:53: float A = fabs((xRed - xBlue) * (yGreen -
yBlue) - (xGreen - xBlue) * (yRed - yBlue)) / 2;
On 2016/02/17 10:42:24, noel gordon wrote:
> nit: Space before this line.
> 
> Also, A -> area.
> 
> float area = fabs((xRed - xBlue) * (yGreen ...
> return area;

Done.

https://codereview.chromium.org/1703553002/diff/1/third_party/qcms/src/qcms_u...
third_party/qcms/src/qcms_util.c:60: float A = get_triangle_area(candidate);
On 2016/02/17 10:42:24, noel gordon wrote:
> nit: A -> area.

Done.

https://codereview.chromium.org/1703553002/diff/1/third_party/qcms/src/qcms_u...
third_party/qcms/src/qcms_util.c:66: qcms_triangle triangle =
get_profile_triangle(profile);
On 2016/02/17 10:42:24, noel gordon wrote:
> nit: alignment / spacing.
> 
> Compare with this alignment of the get_ntsc_gamut_metric_area(), for example. 

> 
> Simple fix: make the alignment in this function consistent with the other
> changes in this file.

Done.

https://codereview.chromium.org/1703553002/diff/1/third_party/qcms/src/tests/...
File third_party/qcms/src/tests/qcms_test_ntsc_gamut.c (right):

https://codereview.chromium.org/1703553002/diff/1/third_party/qcms/src/tests/...
third_party/qcms/src/tests/qcms_test_ntsc_gamut.c:1: // Copyright 2015 The
Chromium Authors. All rights reserved.
On 2016/02/17 10:42:24, noel gordon wrote:
> nit: 2015 -> 2016.

Done.

https://codereview.chromium.org/1703553002/diff/1/third_party/qcms/src/tests/...
third_party/qcms/src/tests/qcms_test_ntsc_gamut.c:28: if (input_path == NULL) {
On 2016/02/17 10:42:25, noel gordon wrote:
> if (!input_path)

Done.

https://codereview.chromium.org/1703553002/diff/1/third_party/qcms/src/tests/...
third_party/qcms/src/tests/qcms_test_ntsc_gamut.c:44: else if
(!(transform->transform_flags & TRANSFORM_FLAG_MATRIX)) {
On 2016/02/17 10:42:24, noel gordon wrote:
> nite: space before this line and then write it as ...
> 
> if (!(transform->transform_flags & TRANSFORM_FLAG_MATRIX)) {

Done.

[radu.velea, 2016-02-17 11:43:24]

The CQ bit was checked by radu.velea@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-17 11:43:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1703553002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1703553002/20001

[commit-bot: I haz the power, 2016-02-17 12:43:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-17 12:43:19]

Dry run: This issue passed the CQ dry run.

[radu.velea, 2016-02-17 12:48:53]

The CQ bit was checked by radu.velea@intel.com

[radu.velea, 2016-02-17 12:48:54]

The patchset sent to the CQ was uploaded after l-g-t-m from noel@chromium.org
Link to the patchset: https://codereview.chromium.org/1703553002/#ps20001
(title: "Removed whitespace and variable rename")

[commit-bot: I haz the power, 2016-02-17 12:49:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1703553002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1703553002/20001

[commit-bot: I haz the power, 2016-02-17 12:54:15]

Description was changed from

==========
[qcms] Provide an API to compute xyY gamut area relative to NTSC 1953

The new API computes profile relative gamut area using (x,y) coordinates. 
This feature will allow a better understanding of the nature of display 
color profiles in use.

This patch contains a test case that displays the new metric for an
input profile and QCMS's internal sRGB profile.

qcms_tests -t qcms_test_ntsc_gamut -i AdobeRGB.icc 
NTSC 1953 relative gamut area test
Input profile
	Description: Adobe RGB (1998)
	NTSC relative gamut area: 92.714 %
Internal reference profile
	Description: sRGB IEC61966-2.1
	NTSC relative gamut area: 68.946 %

BUG=582870
==========

to

==========
[qcms] Provide an API to compute xyY gamut area relative to NTSC 1953

The new API computes profile relative gamut area using (x,y) coordinates. 
This feature will allow a better understanding of the nature of display 
color profiles in use.

This patch contains a test case that displays the new metric for an
input profile and QCMS's internal sRGB profile.

qcms_tests -t qcms_test_ntsc_gamut -i AdobeRGB.icc 
NTSC 1953 relative gamut area test
Input profile
	Description: Adobe RGB (1998)
	NTSC relative gamut area: 92.714 %
Internal reference profile
	Description: sRGB IEC61966-2.1
	NTSC relative gamut area: 68.946 %

BUG=582870
==========

[commit-bot: I haz the power, 2016-02-17 12:54:16]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-17 12:55:15]

Description was changed from

==========
[qcms] Provide an API to compute xyY gamut area relative to NTSC 1953

The new API computes profile relative gamut area using (x,y) coordinates. 
This feature will allow a better understanding of the nature of display 
color profiles in use.

This patch contains a test case that displays the new metric for an
input profile and QCMS's internal sRGB profile.

qcms_tests -t qcms_test_ntsc_gamut -i AdobeRGB.icc 
NTSC 1953 relative gamut area test
Input profile
	Description: Adobe RGB (1998)
	NTSC relative gamut area: 92.714 %
Internal reference profile
	Description: sRGB IEC61966-2.1
	NTSC relative gamut area: 68.946 %

BUG=582870
==========

to

==========
[qcms] Provide an API to compute xyY gamut area relative to NTSC 1953

The new API computes profile relative gamut area using (x,y) coordinates.
This feature will allow a better understanding of the nature of display
color profiles in use.

This patch contains a test case that displays the new metric for an
input profile and QCMS's internal sRGB profile.

qcms_tests -t qcms_test_ntsc_gamut -i AdobeRGB.icc
NTSC 1953 relative gamut area test
Input profile
	Description: Adobe RGB (1998)
	NTSC relative gamut area: 92.714 %
Internal reference profile
	Description: sRGB IEC61966-2.1
	NTSC relative gamut area: 68.946 %

BUG=582870

Committed: https://crrev.com/21e4879ba61638c2b96b77458feb827a7a75563a
Cr-Commit-Position: refs/heads/master@{#375864}
==========

[commit-bot: I haz the power, 2016-02-17 12:55:16]

Patchset 2 (id:??) landed as
https://crrev.com/21e4879ba61638c2b96b77458feb827a7a75563a
Cr-Commit-Position: refs/heads/master@{#375864}