Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 1703533002: [Swarming] Bundle gcmole tools. (Closed)

Created:
4 years, 10 months ago by Michael Achenbach
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Swarming] Bundle gcmole tools. This enables downloading all gcmole dependencies from google storage on demand, controlled by a gyp flag "gcmole=1". This makes the analysis portable to any linux64 host. The archive contains a prebuilt clang in the needed version, the gcmole plugin and a lua binary. The tool can be run through a new wrapper that sets up the environment. This'll ease running it on swarming. BUG=chromium:535160 LOG=n Committed: https://crrev.com/3ec141705090ef9c8f7971f07fbf8aa64a589f4e Cr-Commit-Position: refs/heads/master@{#34046}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Correctly exit wrapper. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -0 lines) Patch
M .gitignore View 1 chunk +2 lines, -0 lines 0 comments Download
M DEPS View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
A tools/gcmole/download_gcmole_tools.py View 1 chunk +22 lines, -0 lines 0 comments Download
A tools/gcmole/gcmole-tools.tar.gz.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/gcmole/run-gcmole.py View 1 2 3 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Michael Achenbach
PTAL
4 years, 10 months ago (2016-02-16 17:33:34 UTC) #3
tandrii(chromium)
lgtm % so, you upload the package manually or did I miss a builder doing ...
4 years, 10 months ago (2016-02-16 18:01:57 UTC) #4
Michael Achenbach
On 2016/02/16 18:01:57, tandrii(chromium) wrote: > lgtm % so, you upload the package manually or ...
4 years, 10 months ago (2016-02-16 18:17:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1703533002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1703533002/60001
4 years, 10 months ago (2016-02-16 18:43:13 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 10 months ago (2016-02-16 19:07:52 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 19:08:01 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3ec141705090ef9c8f7971f07fbf8aa64a589f4e
Cr-Commit-Position: refs/heads/master@{#34046}

Powered by Google App Engine
This is Rietveld 408576698