Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 1703513002: [runtime] More LookupIterator / Transition related performance tweaks (Closed)

Created:
4 years, 10 months ago by Toon Verwaest
Modified:
4 years, 10 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] More LookupIterator / Transition related performance tweaks Minor improvements measured through by https://github.com/kpdecker/six-speed/blob/master/tests/object-assign/object-assign.es6. Mostly due to inlining of NowContains on the FieldType Committed: https://crrev.com/d198717714e1c96375f27a65902e390f53f3a42d Cr-Commit-Position: refs/heads/master@{#34060}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -41 lines) Patch
M src/field-type.h View 1 chunk +9 lines, -2 lines 0 comments Download
M src/field-type.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/lookup.cc View 1 2 chunks +23 lines, -11 lines 0 comments Download
M src/objects.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/objects.cc View 1 4 chunks +10 lines, -12 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Toon Verwaest
ptal
4 years, 10 months ago (2016-02-16 13:51:31 UTC) #2
Camillo Bruni
lgtm
4 years, 10 months ago (2016-02-16 13:58:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1703513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1703513002/1
4 years, 10 months ago (2016-02-16 14:09:17 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/13754) v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, ...
4 years, 10 months ago (2016-02-16 14:10:09 UTC) #7
adamk
DBC: Longer CL description here would be appreciated (in particular, am interested in what's measuring ...
4 years, 10 months ago (2016-02-16 19:48:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1703513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1703513002/20001
4 years, 10 months ago (2016-02-17 08:18:19 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-17 09:06:51 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 09:07:39 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d198717714e1c96375f27a65902e390f53f3a42d
Cr-Commit-Position: refs/heads/master@{#34060}

Powered by Google App Engine
This is Rietveld 408576698