Remove --abort_on_assertion_errors and all associated infrastructure.

runtime/vm/exceptions.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/exceptions.h"
 
 #include "platform/address_sanitizer.h"
 
 #include "vm/dart_api_impl.h"
 #include "vm/dart_entry.h"
 #include "vm/debugger.h"
 #include "vm/flags.h"
 #include "vm/object.h"
 #include "vm/object_store.h"
 #include "vm/stack_frame.h"
 #include "vm/stub_code.h"
 #include "vm/symbols.h"
 #include "vm/tags.h"
 
 namespace dart {
 
-// TODO(vegorov): Remove --abort_on_assertion_errors flag and associated
-// infrastructure (dartbug.com/25753)
-DEFINE_FLAG(bool, abort_on_assertion_errors, false,
-            "Abort on assertion and typecheck failures");
 DEFINE_FLAG(bool, print_stacktrace_at_throw, false,
             "Prints a stack trace everytime a throw occurs.");
 
 
 const char* Exceptions::kCastErrorDstName = "type cast";
 
 
 class StacktraceBuilder : public ValueObject {
  public:
   StacktraceBuilder() { }
@@ skipping 418 matching lines @@
   args.SetAt(2, Smi::Handle(Smi::New(column)));
 
   // Initialize '_srcType', '_dstType', '_dstName', and '_errorMsg'.
   args.SetAt(3, src_type_name);
   args.SetAt(4, dst_type_name);
   args.SetAt(5, dst_name);
   args.SetAt(6, error_msg);
 
   // Type errors in the core library may be difficult to diagnose.
   // Print type error information before throwing the error when debugging.
-  if (FLAG_print_stacktrace_at_throw || FLAG_abort_on_assertion_errors) {
+  if (FLAG_print_stacktrace_at_throw) {
     if (!error_msg.IsNull()) {
       OS::Print("%s\n", error_msg.ToCString());
     }
     OS::Print("'%s': Failed type check: line %" Pd " pos %" Pd ": ",
               String::Handle(script.url()).ToCString(), line, column);
     if (!dst_name.IsNull() && (dst_name.Length() > 0)) {
       OS::Print("type '%s' is not a subtype of type '%s' of '%s'.\n",
                 src_type_name.ToCString(),
                 dst_type_name.ToCString(),
                 dst_name.ToCString());
     } else {
       OS::Print("type error.\n");
     }
   }
 
-  if (FLAG_abort_on_assertion_errors) {
-    PrintStackTraceAndAbort("a type error");
-  }
-
   // Throw TypeError or CastError instance.
   Exceptions::ThrowByType(exception_type, args);
   UNREACHABLE();
 }
 
 
 void Exceptions::Throw(Thread* thread, const Instance& exception) {
   // Do not notify debugger on stack overflow and out of memory exceptions.
   // The VM would crash when the debugger calls back into the VM to
   // get values of variables.
@@ skipping 171 matching lines @@
       class_name = &Symbols::CyclicInitializationError();
   }
 
   return DartLibraryCalls::InstanceCreate(library,
                                           *class_name,
                                           *constructor_name,
                                           arguments);
 }
 
 
-static bool IsLikelyInternalDart2JSCrash(const Stacktrace& stacktrace) {
-  Function& function = Function::Handle();
-  String& name = String::Handle();
-  for (intptr_t i = 0, len = stacktrace.Length(); i < len; i++) {
-    function = stacktrace.FunctionAtFrame(i);
-    name = function.QualifiedPrettyName();
-    if (name.Equals("_CompilerDiagnosticReporter.withCurrentElement")) {
-      return true;
-    }
-  }
-  return false;
-}
-
-
-void Exceptions::PrintStackTraceAndAbort(const char* reason) {
-  const Stacktrace& stacktrace = Stacktrace::Handle(CurrentStacktrace());
-  if (!IsLikelyInternalDart2JSCrash(stacktrace)) {
-    return;
-  }
-
-  OS::PrintErr("\n\n\nAborting due to %s. Stacktrace:\n%s\n",
-               reason,
-               stacktrace.ToCString());
-  OS::Abort();
-}
-
 }  // namespace dart