Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: src/effects/SkBlurMask.cpp

Issue 17035007: Fix quickReject computation for blurs (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: New version based on in-person reviews Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/effects/SkBlurMask.cpp
===================================================================
--- src/effects/SkBlurMask.cpp (revision 9604)
+++ src/effects/SkBlurMask.cpp (working copy)
@@ -12,14 +12,10 @@
#include "SkTemplates.h"
#include "SkEndian.h"
-// scale factor for the blur radius to match the behavior of the all existing blur
-// code (both on the CPU and the GPU). This magic constant is 1/sqrt(3).
+const SkScalar SkBlurMask::kBLUR_SIGMA_SCALE = SkFloatToScalar(0.6f);
+const SkScalar SkBlurMask::kMAX_BLUR_RADIUS = SkIntToScalar(128);
+const SkScalar SkBlurMask::kBlurRadiusFudgeFactor = SkFloatToScalar(.57735f);
-// TODO: get rid of this fudge factor and move any required fudging up into
-// the calling library
-
-#define kBlurRadiusFudgeFactor SkFloatToScalar( .57735f )
-
#define UNROLL_SEPARABLE_LOOPS
/**

Powered by Google App Engine
This is Rietveld 408576698