media/audio/audio_input_device.cc - Issue 1703473002: Make AudioOutputDevice restartable and reinitializable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/audio_input_device.cc

Issue 1703473002: Make AudioOutputDevice restartable and reinitializable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@new_mixing

Patch Set: Changes from olka@, adding callback lock, removing stopping hack, rebase. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/audio/audio_input_device.cc

diff --git a/media/audio/audio_input_device.cc b/media/audio/audio_input_device.cc

index fc6b39285ad363aeb2e7591eacfcd77b8d97bfbb..04b91d6bb72c3b6420cdea93e2107d4a3a53d16a 100644

--- a/media/audio/audio_input_device.cc

+++ b/media/audio/audio_input_device.cc

@@ -146,8 +146,8 @@ void AudioInputDevice::OnStreamCreated(

DCHECK(audio_thread_.IsStopped());

audio_callback_.reset(new AudioInputDevice::AudioThreadCallback(

audio_parameters_, handle, length, total_segments, callback_));

- audio_thread_.Start(

- audio_callback_.get(), socket_handle, "AudioInputDevice", true);

+ audio_thread_.Start("AudioInputDevice", true);

+ audio_thread_.Play(audio_callback_.get(), socket_handle);

state_ = RECORDING;

ipc_->RecordStream();

« media/audio/audio_device_thread.h ('K') | « media/audio/audio_device_thread.cc ('k') | media/audio/audio_output_device.h » ('j') | no next file with comments »