content/renderer/media/webrtc_local_audio_renderer.cc - Issue 1703473002: Make AudioOutputDevice restartable and reinitializable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc_local_audio_renderer.cc

Issue 1703473002: Make AudioOutputDevice restartable and reinitializable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@new_mixing

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/webrtc/webrtc_local_audio_track_adapter.cc ('k') | content/renderer/media/webrtc_local_audio_track.cc » ('j') | media/audio/audio_device_thread.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webrtc_local_audio_renderer.cc

diff --git a/content/renderer/media/webrtc_local_audio_renderer.cc b/content/renderer/media/webrtc_local_audio_renderer.cc

index 0a618f6ab4246c6f1bf1b24c7dcb1442e8382fa6..4c45c40989748793f2df84ef80cfd192bf7426cd 100644

--- a/content/renderer/media/webrtc_local_audio_renderer.cc

+++ b/content/renderer/media/webrtc_local_audio_renderer.cc

@@ -38,6 +38,7 @@ enum LocalRendererSinkStates {

int WebRtcLocalAudioRenderer::Render(media::AudioBus* audio_bus,

uint32_t audio_delay_milliseconds,

uint32_t frames_skipped) {

+// NOTREACHED();

TRACE_EVENT0("audio", "WebRtcLocalAudioRenderer::Render");

base::AutoLock auto_lock(thread_lock_);

@@ -61,7 +62,7 @@ void WebRtcLocalAudioRenderer::OnRenderError() {

// content::MediaStreamAudioSink implementation

void WebRtcLocalAudioRenderer::OnData(const media::AudioBus& audio_bus,

base::TimeTicks estimated_capture_time) {

- DCHECK(capture_thread_checker_.CalledOnValidThread());

+// DCHECK(capture_thread_checker_.CalledOnValidThread());

DCHECK(!estimated_capture_time.is_null());

TRACE_EVENT0("audio", "WebRtcLocalAudioRenderer::CaptureData");