Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Unified Diff: src/interpreter/bytecode-generator.cc

Issue 1703453002: [interpreter, debugger] support debug breaks via bytecode array copy (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/interpreter/bytecode-generator.cc
diff --git a/src/interpreter/bytecode-generator.cc b/src/interpreter/bytecode-generator.cc
index c0f5750351784b62d0f57247e94e22bc076487b7..3aad14b067f68443c64dd8fa0e5912b516a4e2ed 100644
--- a/src/interpreter/bytecode-generator.cc
+++ b/src/interpreter/bytecode-generator.cc
@@ -898,7 +898,7 @@ void BytecodeGenerator::VisitBreakStatement(BreakStatement* stmt) {
void BytecodeGenerator::VisitReturnStatement(ReturnStatement* stmt) {
VisitForAccumulatorValue(stmt->expression());
- builder()->SetReturnPosition(info_->literal());
+ builder()->SetStatementPosition(stmt);
Yang 2016/02/16 09:22:20 Turns out I've been wrong about setting the return
rmcilroy 2016/02/16 10:46:38 Ack. Note: we will only get a SetReturnPosition no
Yang 2016/02/19 13:09:17 Done.
execution_control()->ReturnAccumulator();
}

Powered by Google App Engine
This is Rietveld 408576698