Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: src/compiler/bytecode-graph-builder.cc

Issue 1703453002: [interpreter, debugger] support debug breaks via bytecode array copy (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: addressed last comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/bytecode-graph-builder.h" 5 #include "src/compiler/bytecode-graph-builder.h"
6 6
7 #include "src/compiler/bytecode-branch-analysis.h" 7 #include "src/compiler/bytecode-branch-analysis.h"
8 #include "src/compiler/linkage.h" 8 #include "src/compiler/linkage.h"
9 #include "src/compiler/operator-properties.h" 9 #include "src/compiler/operator-properties.h"
10 #include "src/interpreter/bytecodes.h" 10 #include "src/interpreter/bytecodes.h"
(...skipping 1418 matching lines...) Expand 10 before | Expand all | Expand 10 after
1429 MergeControlToLeaveFunction(control); 1429 MergeControlToLeaveFunction(control);
1430 } 1430 }
1431 1431
1432 void BytecodeGraphBuilder::VisitDebugger() { 1432 void BytecodeGraphBuilder::VisitDebugger() {
1433 FrameStateBeforeAndAfter states(this); 1433 FrameStateBeforeAndAfter states(this);
1434 Node* call = 1434 Node* call =
1435 NewNode(javascript()->CallRuntime(Runtime::kHandleDebuggerStatement)); 1435 NewNode(javascript()->CallRuntime(Runtime::kHandleDebuggerStatement));
1436 environment()->BindAccumulator(call, &states); 1436 environment()->BindAccumulator(call, &states);
1437 } 1437 }
1438 1438
1439 // We cannot create a graph from the debugger copy of the bytecode array.
1440 #define DEBUG_BREAK(Name, ...) \
1441 void BytecodeGraphBuilder::Visit##Name() { UNREACHABLE(); }
1442 DEBUG_BREAK_BYTECODE_LIST(DEBUG_BREAK);
1443 #undef DEBUG_BREAK
1444
1439 void BytecodeGraphBuilder::BuildForInPrepare() { 1445 void BytecodeGraphBuilder::BuildForInPrepare() {
1440 FrameStateBeforeAndAfter states(this); 1446 FrameStateBeforeAndAfter states(this);
1441 Node* receiver = environment()->LookupAccumulator(); 1447 Node* receiver = environment()->LookupAccumulator();
1442 Node* prepare = NewNode(javascript()->ForInPrepare(), receiver); 1448 Node* prepare = NewNode(javascript()->ForInPrepare(), receiver);
1443 environment()->BindRegistersToProjections( 1449 environment()->BindRegistersToProjections(
1444 bytecode_iterator().GetRegisterOperand(0), prepare, &states); 1450 bytecode_iterator().GetRegisterOperand(0), prepare, &states);
1445 } 1451 }
1446 1452
1447 void BytecodeGraphBuilder::VisitForInPrepare() { BuildForInPrepare(); } 1453 void BytecodeGraphBuilder::VisitForInPrepare() { BuildForInPrepare(); }
1448 1454
(...skipping 303 matching lines...) Expand 10 before | Expand all | Expand 10 after
1752 // Phi does not exist yet, introduce one. 1758 // Phi does not exist yet, introduce one.
1753 value = NewPhi(inputs, value, control); 1759 value = NewPhi(inputs, value, control);
1754 value->ReplaceInput(inputs - 1, other); 1760 value->ReplaceInput(inputs - 1, other);
1755 } 1761 }
1756 return value; 1762 return value;
1757 } 1763 }
1758 1764
1759 } // namespace compiler 1765 } // namespace compiler
1760 } // namespace internal 1766 } // namespace internal
1761 } // namespace v8 1767 } // namespace v8
OLDNEW
« no previous file with comments | « src/arm64/builtins-arm64.cc ('k') | src/debug/debug.h » ('j') | src/debug/debug-frames.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698