Issue 170343003: Directly store the transition target on LookupResult in TransitionResult.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 170343003: Directly store the transition target on LookupResult in TransitionResult. (Closed)

Created:
6 years, 10 months ago by Toon Verwaest

Modified:
6 years, 10 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Directly store the transition target on LookupResult in TransitionResult. BUG=chromium:343964 LOG=N R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19440

Patch Set 2 : Remove crankshaft-local caching #

Total comments: 1

Patch Set 3 : #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -56 lines)			Patch
M	src/hydrogen.h	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	src/hydrogen.cc	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/ic.cc	View		3 chunks	+4 lines, -9 lines	0 comments	Download
M	src/objects.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/objects-inl.h	View		2 chunks	+7 lines, -1 line	0 comments	Download
M	src/property.h	View	1 2	9 chunks	+17 lines, -35 lines	0 comments	Download
M	src/property.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/transitions-inl.h	View		1 chunk	+1 line, -3 lines	0 comments	Download
A	test/mjsunit/regress/regress-lookup-transition.js	View		1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

lgtm https://codereview.chromium.org/170343003/diff/30001/src/property.h File src/property.h (right): https://codereview.chromium.org/170343003/diff/30001/src/property.h#newcode219 src/property.h:219: number_ = 0x89ABCDEF; nit: please pick a number ...

6 years, 10 months ago (2014-02-18 12:09:52 UTC) #2

Toon Verwaest

6 years, 10 months ago (2014-02-18 12:19:42 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r19440 (presubmit successful).