Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 170343002: Reland "Allow ICs to be generated for own global proxy." (Closed)

Created:
6 years, 10 months ago by Toon Verwaest
Modified:
6 years, 10 months ago
Reviewers:
dcarney
CC:
v8-dev
Visibility:
Public.

Description

Reland "Allow ICs to be generated for own global proxy." BUG= R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19430

Patch Set 1 #

Patch Set 2 : Fix setting through global proxy without interceptor setter. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -62 lines) Patch
M src/arm/stub-cache-arm.cc View 1 2 chunks +0 lines, -19 lines 0 comments Download
M src/code-stubs.h View 3 chunks +19 lines, -7 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +8 lines, -5 lines 0 comments Download
M src/ic.cc View 1 6 chunks +19 lines, -21 lines 0 comments Download
M src/isolate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/objects-inl.h View 2 chunks +10 lines, -3 lines 0 comments Download
M src/runtime.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 10 months ago (2014-02-18 10:03:20 UTC) #1
dcarney
lgtm
6 years, 10 months ago (2014-02-18 10:09:36 UTC) #2
Toon Verwaest
6 years, 10 months ago (2014-02-18 10:10:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r19430 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698