Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2089)

Unified Diff: components/safe_browsing_db/BUILD.gn

Issue 1703413002: Move common PVer4 code into a V4ProtocolManagerUtil class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Pass config as pointer, instead of reference Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/safe_browsing_db.gypi ('k') | components/safe_browsing_db/database_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/safe_browsing_db/BUILD.gn
diff --git a/components/safe_browsing_db/BUILD.gn b/components/safe_browsing_db/BUILD.gn
index f91450709886dd67e4b889128f7fdcfbd11b5f60..9aa781c68cbb47170200698ac15f93f4477d2ced 100644
--- a/components/safe_browsing_db/BUILD.gn
+++ b/components/safe_browsing_db/BUILD.gn
@@ -81,22 +81,6 @@ source_set("prefix_set") {
]
}
-source_set("v4_get_hash_protocol_manager") {
- sources = [
- "v4_get_hash_protocol_manager.cc",
- "v4_get_hash_protocol_manager.h",
- ]
- public_deps = [
- ":proto",
- ]
- deps = [
- ":util",
- "//base",
- "//net",
- "//url:url",
- ]
-}
-
source_set("remote_database_manager") {
sources = [
"remote_database_manager.cc",
@@ -164,18 +148,49 @@ source_set("test_database_manager") {
]
}
+source_set("v4_get_hash_protocol_manager") {
+ sources = [
+ "v4_get_hash_protocol_manager.cc",
+ "v4_get_hash_protocol_manager.h",
+ ]
+ public_deps = [
+ ":proto",
+ ]
+ deps = [
+ ":util",
+ ":v4_protocol_manager_util",
+ "//base",
+ "//net",
+ "//url:url",
+ ]
+}
+
+source_set("v4_protocol_manager_util") {
+ sources = [
+ "v4_protocol_manager_util.cc",
+ "v4_protocol_manager_util.h",
+ ]
+ deps = [
+ "//base",
+ "//net",
+ "//url:url",
+ ]
+}
+
source_set("unit_tests") {
testonly = true
sources = [
"prefix_set_unittest.cc",
"util_unittest.cc",
"v4_get_hash_protocol_manager_unittest.cc",
+ "v4_protocol_manager_util_unittest.cc",
]
deps = [
":prefix_set",
":proto",
":util",
":v4_get_hash_protocol_manager",
+ ":v4_protocol_manager_util",
"//base",
"//net",
"//net:test_support",
« no previous file with comments | « components/safe_browsing_db.gypi ('k') | components/safe_browsing_db/database_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698