Move common PVer4 code into a V4ProtocolManagerUtil class.

components/safe_browsing_db/v4_get_hash_protocol_manager_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/base64.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/stringprintf.h"
 #include "base/time/time.h"
@@ skipping 15 matching lines @@
 const char kAppVer[] = "1.0";
 const char kKeyParam[] = "test_key_param";
 
 }  // namespace
 
 namespace safe_browsing {
 
 class SafeBrowsingV4GetHashProtocolManagerTest : public testing::Test {
  protected:
   scoped_ptr<V4GetHashProtocolManager> CreateProtocolManager() {
-    V4GetHashProtocolConfig config;
+    V4ProtocolConfig config;
     config.client_name = kClient;
     config.version = kAppVer;
     config.key_param = kKeyParam;
     return scoped_ptr<V4GetHashProtocolManager>(
         V4GetHashProtocolManager::Create(NULL, config));
   }
 
   std::string GetStockV4HashResponse() {
     FindFullHashesResponse res;
     res.mutable_negative_cache_duration()->set_seconds(600);
@@ skipping 109 matching lines @@
   fetcher->set_status(net::URLRequestStatus());
   fetcher->set_response_code(200);
   fetcher->SetResponseString(GetStockV4HashResponse());
   fetcher->delegate()->OnURLFetchComplete(fetcher);
 
   // No error, back off multiplier is unchanged.
   EXPECT_EQ(0ul, pm->gethash_error_count_);
   EXPECT_EQ(1ul, pm->gethash_back_off_mult_);
 }
 
-TEST_F(SafeBrowsingV4GetHashProtocolManagerTest, TestGetHashBackOffTimes) {
-  scoped_ptr<V4GetHashProtocolManager> pm(CreateProtocolManager());
-
-  // No errors or back off time yet.
-  EXPECT_EQ(0U, pm->gethash_error_count_);
-  EXPECT_EQ(1U, pm->gethash_back_off_mult_);
-  Time now = Time::Now();
-  EXPECT_TRUE(pm->next_gethash_time_ < now);
-
-  // 1 error.
-  pm->HandleGetHashError(now);
-  EXPECT_EQ(1U, pm->gethash_error_count_);
-  EXPECT_EQ(1U, pm->gethash_back_off_mult_);
-  EXPECT_LE(now + TimeDelta::FromMinutes(15), pm->next_gethash_time_);
-  EXPECT_GE(now + TimeDelta::FromMinutes(30), pm->next_gethash_time_);
-
-  // 2 errors.
-  pm->HandleGetHashError(now);
-  EXPECT_EQ(2U, pm->gethash_error_count_);
-  EXPECT_EQ(2U, pm->gethash_back_off_mult_);
-  EXPECT_LE(now + TimeDelta::FromMinutes(30), pm->next_gethash_time_);
-  EXPECT_GE(now + TimeDelta::FromMinutes(60), pm->next_gethash_time_);
-
-  // 3 errors.
-  pm->HandleGetHashError(now);
-  EXPECT_EQ(3U, pm->gethash_error_count_);
-  EXPECT_EQ(4U, pm->gethash_back_off_mult_);
-  EXPECT_LE(now + TimeDelta::FromMinutes(60), pm->next_gethash_time_);
-  EXPECT_GE(now + TimeDelta::FromMinutes(120), pm->next_gethash_time_);
-
-  // 4 errors.
-  pm->HandleGetHashError(now);
-  EXPECT_EQ(4U, pm->gethash_error_count_);
-  EXPECT_EQ(8U, pm->gethash_back_off_mult_);
-  EXPECT_LE(now + TimeDelta::FromMinutes(120), pm->next_gethash_time_);
-  EXPECT_GE(now + TimeDelta::FromMinutes(240), pm->next_gethash_time_);
-
-  // 5 errors.
-  pm->HandleGetHashError(now);
-  EXPECT_EQ(5U, pm->gethash_error_count_);
-  EXPECT_EQ(16U, pm->gethash_back_off_mult_);
-  EXPECT_LE(now + TimeDelta::FromMinutes(240), pm->next_gethash_time_);
-  EXPECT_GE(now + TimeDelta::FromMinutes(480), pm->next_gethash_time_);
-
-  // 6 errors.
-  pm->HandleGetHashError(now);
-  EXPECT_EQ(6U, pm->gethash_error_count_);
-  EXPECT_EQ(32U, pm->gethash_back_off_mult_);
-  EXPECT_LE(now + TimeDelta::FromMinutes(480), pm->next_gethash_time_);
-  EXPECT_GE(now + TimeDelta::FromMinutes(960), pm->next_gethash_time_);
-
-  // 7 errors.
-  pm->HandleGetHashError(now);
-  EXPECT_EQ(7U, pm->gethash_error_count_);
-  EXPECT_EQ(64U, pm->gethash_back_off_mult_);
-  EXPECT_LE(now + TimeDelta::FromMinutes(960), pm->next_gethash_time_);
-  EXPECT_GE(now + TimeDelta::FromMinutes(1920), pm->next_gethash_time_);
-
-  // 8 errors, reached max backoff.
-  pm->HandleGetHashError(now);
-  EXPECT_EQ(8U, pm->gethash_error_count_);
-  EXPECT_EQ(128U, pm->gethash_back_off_mult_);
-  EXPECT_EQ(now + TimeDelta::FromHours(24), pm->next_gethash_time_);
-
-  // 9 errors, reached max backoff and multiplier capped.
-  pm->HandleGetHashError(now);
-  EXPECT_EQ(9U, pm->gethash_error_count_);
-  EXPECT_EQ(128U, pm->gethash_back_off_mult_);
-  EXPECT_EQ(now + TimeDelta::FromHours(24), pm->next_gethash_time_);
-}
-
-TEST_F(SafeBrowsingV4GetHashProtocolManagerTest, TestGetHashUrl) {
-  scoped_ptr<V4GetHashProtocolManager> pm(CreateProtocolManager());
-
-  EXPECT_EQ(
-      "https://safebrowsing.googleapis.com/v4/encodedFullHashes/request_base64?"
-      "alt=proto&client_id=unittest&client_version=1.0&key=test_key_param",
-      pm->GetHashUrl("request_base64").spec());
-}
-
 TEST_F(SafeBrowsingV4GetHashProtocolManagerTest, TestGetHashRequest) {
   scoped_ptr<V4GetHashProtocolManager> pm(CreateProtocolManager());
 
   FindFullHashesRequest req;
   ThreatInfo* info = req.mutable_threat_info();
   info->add_threat_types(API_ABUSE);
   info->add_platform_types(CHROME_PLATFORM);
   info->add_threat_entry_types(URL_EXPRESSION);
 
   SBPrefix one = 1u;
@@ skipping 167 matching lines @@
   // Serialize.
   std::string res_data;
   res.SerializeToString(&res_data);
 
   std::vector<SBFullHashResult> full_hashes;
   base::TimeDelta cache_lifetime;
   EXPECT_FALSE(pm->ParseHashResponse(res_data, &full_hashes, &cache_lifetime));
 }
 
 }  // namespace safe_browsing