Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1703403002: remove kDisableMinimizeOnSecondLauncherItemClick (Closed)

Created:
4 years, 10 months ago by Evan Stade
Modified:
4 years, 10 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, kalyank, sadrul, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

remove kDisableMinimizeOnSecondLauncherItemClick BUG=587702 Committed: https://crrev.com/8a1c21598ca74605325581eb014da85d8550f65f Cr-Commit-Position: refs/heads/master@{#376283}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -82 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 1 chunk +6 lines, -13 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc View 2 chunks +1 line, -58 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Evan Stade
4 years, 10 months ago (2016-02-18 02:57:22 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1703403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1703403002/1
4 years, 10 months ago (2016-02-18 02:58:59 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-18 03:39:22 UTC) #6
stevenjb
lgtm
4 years, 10 months ago (2016-02-18 17:07:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1703403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1703403002/1
4 years, 10 months ago (2016-02-18 21:22:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-18 21:53:19 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 21:55:40 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8a1c21598ca74605325581eb014da85d8550f65f
Cr-Commit-Position: refs/heads/master@{#376283}

Powered by Google App Engine
This is Rietveld 408576698