Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: scripts/slave/gatekeeper.json

Issue 1703353002: Attempt to make GN waterfall bots not on the CQ alert but not close trees. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: patch for review Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/gatekeeper.json
diff --git a/scripts/slave/gatekeeper.json b/scripts/slave/gatekeeper.json
index d88151b92447190578ef681f21c1ffb8254ef3b6..901a5d8f71782805106ea184c8023f77991c89e2 100644
--- a/scripts/slave/gatekeeper.json
+++ b/scripts/slave/gatekeeper.json
@@ -258,6 +258,11 @@
"categories": [
"chromium_tree_closer"
],
+ "comment": [
+ "TODO(dpranke): crbug.com/486089, crbug.com/439402",
+ "Until the Mac GN (dbg) bot is in the CQ, it should not close the",
+ "tree."
+ ],
"builders": {
"iOS_Device": {
"sheriff_classes": ["sheriff_ios_europe", "sheriff_ios_us"]
@@ -270,17 +275,11 @@
"iOS_Device_(ninja)": {
"sheriff_classes": ["sheriff_ios_europe", "sheriff_ios_us"]
},
+ "Mac GN (dbg)": {
+ "close_tree": false
ghost stip (do not use) 2016/02/26 01:01:51 IIUC this feature isn't particularly used and may
+ },
"*": {}
- },
-
- "comment": [
- "TODO(dpranke): crbug.com/486089, crbug.com/439402",
- "Until these are in the CQ, they should not close the tree."
- ],
- "excluded_builders": [
- "Mac GN (dbg)"
- ]
-
+ }
}
],
"https://build.chromium.org/p/chromium.memory": [
@@ -392,19 +391,23 @@
"categories": [
"chromium_tree_closer"
],
- "builders": {
- "*": {}
- },
"comment": [
"TODO(dpranke): crbug.com/486089, crbug.com/439402",
- "Until these are in the CQ, they should not close the tree."
+ "Until the GN bots are in the CQ, they should not close the tree."
],
- "excluded_builders": [
- "Win x64 GN",
- "Win x64 GN (dbg)",
- "Win8 GN (dbg)"
- ]
+ "builders": {
+ "Win x64 GN": {
+ "close_tree": false
+ },
+ "Win x64 GN (dbg)": {
+ "close_tree": false
+ },
+ "Win8 GN (dbg)": {
+ "close_tree": false
+ },
+ "*": {}
+ }
}
],
"https://build.chromium.org/p/client.boringssl": [
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698