Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1703333002: Fix a test race - synchronize test completion to media's loadstart event. (Closed)

Created:
4 years, 10 months ago by Łukasz Anforowicz
Modified:
4 years, 10 months ago
Reviewers:
estark
CC:
chromium-reviews, blink-reviews, alexmos, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a race - synchronize test completion with media's loadstart event. Presence of OOPIFs introduces a delay into loading of cross-origin media and exposes a race in the http/tests/security/mixedContent/insecure-audio-video-in-main-frame.html test. To get rid of the race, we should wait until media has actually started to load, before posting / reporting that the test is "done". BUG=582541 TEST=The affected test passes when run 100 times with and without --site-per-process flag. Committed: https://crrev.com/7723a589545f0d5b59ad792f6285fe9cb5a46c7a Cr-Commit-Position: refs/heads/master@{#376065}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -7 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/site-per-process View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/mixedContent/resources/frame-with-insecure-audio-video.html View 1 chunk +22 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Łukasz Anforowicz
Emily, can you take a look please?
4 years, 10 months ago (2016-02-18 00:13:36 UTC) #4
estark
LGTM, thanks!
4 years, 10 months ago (2016-02-18 00:56:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1703333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1703333002/1
4 years, 10 months ago (2016-02-18 00:59:13 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-18 02:17:14 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 02:18:06 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7723a589545f0d5b59ad792f6285fe9cb5a46c7a
Cr-Commit-Position: refs/heads/master@{#376065}

Powered by Google App Engine
This is Rietveld 408576698