Tell IDB frontend about data loss

content/browser/indexed_db/indexed_db_factory.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/indexed_db/indexed_db_factory.h"
 
 #include "base/logging.h"
 #include "base/strings/utf_string_conversions.h"
 #include "content/browser/indexed_db/indexed_db_backing_store.h"
 #include "content/browser/indexed_db/indexed_db_database.h"
@@ skipping 37 matching lines @@
   DCHECK(database_backend_map_.find(unique_identifier) !=
          database_backend_map_.end());
   database_backend_map_.erase(unique_identifier);
 }
 
 void IndexedDBFactory::GetDatabaseNames(
     scoped_refptr<IndexedDBCallbacksWrapper> callbacks,
     const string16& database_identifier,
     const base::FilePath& data_directory) {
   IDB_TRACE("IndexedDBFactory::get_database_names");
+  bool data_loss;

[jsbell, 2013/06/14 20:42:58]

Add a TODO to figure out if this should be plumbed back to script when this API
gets a more robust design?

[dgrogan, 2013/06/14 22:06:43]

Done.

   scoped_refptr<IndexedDBBackingStore> backing_store =
-      OpenBackingStore(database_identifier, data_directory);
+      OpenBackingStore(database_identifier, data_directory, &data_loss);
   if (!backing_store.get()) {
     callbacks->OnError(
         IndexedDBDatabaseError(WebKit::WebIDBDatabaseExceptionUnknownError,
                                "Internal error opening backing store for "
                                "indexedDB.webkitGetDatabaseNames."));
     return;
   }
 
   callbacks->OnSuccess(backing_store->GetDatabaseNames());
 }
@@ skipping 10 matching lines @@
   IndexedDBDatabaseMap::iterator it =
       database_backend_map_.find(unique_identifier);
   if (it != database_backend_map_.end()) {
     // If there are any connections to the database, directly delete the
     // database.
     it->second->DeleteDatabase(callbacks);
     return;
   }
 
   // TODO(jsbell): Everything from now on should be done on another thread.
+  bool data_loss;

[jsbell, 2013/06/14 20:42:58]

Also add a TODO here?

[dgrogan, 2013/06/14 22:06:43]

Done.

   scoped_refptr<IndexedDBBackingStore> backing_store =
-      OpenBackingStore(database_identifier, data_directory);
+      OpenBackingStore(database_identifier, data_directory, &data_loss);
   if (!backing_store.get()) {
     callbacks->OnError(IndexedDBDatabaseError(
         WebKit::WebIDBDatabaseExceptionUnknownError,
         ASCIIToUTF16("Internal error opening backing store "
                      "for indexed_db.delete_database.")));
     return;
   }
 
   scoped_refptr<IndexedDBDatabase> database_backend = IndexedDBDatabase::Create(
       name, backing_store.get(), this, unique_identifier);
   if (!database_backend.get()) {
     callbacks->OnError(IndexedDBDatabaseError(
         WebKit::WebIDBDatabaseExceptionUnknownError,
         ASCIIToUTF16("Internal error creating database backend for "
                      "indexed_db.delete_database.")));
     return;
   }
 
   database_backend_map_[unique_identifier] = database_backend.get();
   database_backend->DeleteDatabase(callbacks);
   database_backend_map_.erase(unique_identifier);
 }
 
 scoped_refptr<IndexedDBBackingStore> IndexedDBFactory::OpenBackingStore(
     const string16& database_identifier,
-    const base::FilePath& data_directory) {
+    const base::FilePath& data_directory,
+    bool* data_loss) {
   const string16 file_identifier = ComputeFileIdentifier(database_identifier);
   const bool open_in_memory = data_directory.empty();
 
   IndexedDBBackingStoreMap::iterator it2 =
       backing_store_map_.find(file_identifier);
   if (it2 != backing_store_map_.end() && it2->second.get())
     return it2->second.get();
 
   scoped_refptr<IndexedDBBackingStore> backing_store;
   if (open_in_memory) {
     backing_store = IndexedDBBackingStore::OpenInMemory(file_identifier);
   } else {
     backing_store = IndexedDBBackingStore::Open(
-        database_identifier, data_directory, file_identifier);
+        database_identifier, data_directory, file_identifier, data_loss);
   }
 
   if (backing_store.get()) {
     CleanWeakMap(&backing_store_map_);
     backing_store_map_[file_identifier] = backing_store->GetWeakPtr();
     // If an in-memory database, bind lifetime to this factory instance.
     if (open_in_memory)
       session_only_backing_stores_.insert(backing_store);
 
     // All backing stores associated with this factory should be of the same
@@ skipping 14 matching lines @@
     scoped_refptr<IndexedDBDatabaseCallbacksWrapper> database_callbacks,
     const string16& database_identifier,
     const base::FilePath& data_directory) {
   IDB_TRACE("IndexedDBFactory::open");
   const string16 unique_identifier =
       ComputeUniqueIdentifier(name, database_identifier);
 
   scoped_refptr<IndexedDBDatabase> database_backend;
   IndexedDBDatabaseMap::iterator it =
       database_backend_map_.find(unique_identifier);
+  bool data_loss = false;
   if (it == database_backend_map_.end()) {
     scoped_refptr<IndexedDBBackingStore> backing_store =
-        OpenBackingStore(database_identifier, data_directory);
+        OpenBackingStore(database_identifier, data_directory, &data_loss);
     if (!backing_store.get()) {
       callbacks->OnError(IndexedDBDatabaseError(
           WebKit::WebIDBDatabaseExceptionUnknownError,
           ASCIIToUTF16(
               "Internal error opening backing store for indexedDB.open.")));
       return;
     }
 
     database_backend = IndexedDBDatabase::Create(
         name, backing_store.get(), this, unique_identifier);
     if (!database_backend.get()) {
       callbacks->OnError(IndexedDBDatabaseError(
           WebKit::WebIDBDatabaseExceptionUnknownError,
           ASCIIToUTF16(
               "Internal error creating database backend for indexedDB.open.")));
       return;
     }
 
     database_backend_map_[unique_identifier] = database_backend.get();
   } else {
     database_backend = it->second;
   }
 
   database_backend->OpenConnection(
-      callbacks, database_callbacks, transaction_id, version);
+      callbacks, database_callbacks, transaction_id, version, data_loss);
 }
 
 }  // namespace content