Tell IDB frontend about data loss

content/browser/in_process_webkit/indexed_db_callbacks.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/in_process_webkit/indexed_db_callbacks.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "content/browser/indexed_db/indexed_db_metadata.h"
 #include "content/browser/indexed_db/webidbdatabase_impl.h"
 #include "content/common/indexed_db/indexed_db_messages.h"
 #include "webkit/browser/quota/quota_manager.h"
 
 using WebKit::WebData;
+using WebKit::WebIDBCallbacks;
 using WebKit::WebString;
 
 namespace content {
 
 namespace {
 const int32 kDatabaseNotAdded = -1;
 }
 
 IndexedDBCallbacksBase::IndexedDBCallbacksBase(
     IndexedDBDispatcherHost* dispatcher_host,
@@ skipping 18 matching lines @@
 void IndexedDBCallbacksBase::onSuccess(const std::vector<string16>& value) {
   NOTREACHED();
 }
 
 void IndexedDBCallbacksBase::onSuccess(
     WebIDBDatabaseImpl* idb_object,
     const IndexedDBDatabaseMetadata& metadata) {
   NOTREACHED();
 }
 
-void IndexedDBCallbacksBase::onUpgradeNeeded(long long old_version,
-                                             WebIDBDatabaseImpl* database,
-                                             const IndexedDBDatabaseMetadata&) {
+void IndexedDBCallbacksBase::onUpgradeNeeded(
+    long long old_version,
+    WebIDBDatabaseImpl* database,
+    const IndexedDBDatabaseMetadata&,

[jsbell, 2013/06/17 23:21:48]

Not new in this patch, but name the argument: /*metadata*/

[dgrogan, 2013/06/17 23:52:40]

Done.

+    WebKit::WebIDBCallbacks::DataLoss data_loss) {
   NOTREACHED();
 }
 
 void IndexedDBCallbacksBase::onSuccess(WebIDBCursorImpl* idb_object,
                                        const IndexedDBKey& key,
                                        const IndexedDBKey& primaryKey,
                                        std::vector<char>* value) {
   NOTREACHED();
 }
 
@@ skipping 59 matching lines @@
       new IndexedDBMsg_CallbacksSuccessIDBDatabase(ipc_thread_id(),
                                                    ipc_callbacks_id(),
                                                    ipc_database_callbacks_id_,
                                                    ipc_object_id,
                                                    idb_metadata));
 }
 
 void IndexedDBCallbacksDatabase::onUpgradeNeeded(
     long long old_version,
     WebIDBDatabaseImpl* database,
-    const IndexedDBDatabaseMetadata& metadata) {
+    const IndexedDBDatabaseMetadata& metadata,
+    WebIDBCallbacks::DataLoss data_loss) {
   dispatcher_host()->RegisterTransactionId(host_transaction_id_, origin_url_);
   int32 ipc_database_id =
       dispatcher_host()->Add(database, ipc_thread_id(), origin_url_);
   ipc_database_id_ = ipc_database_id;
   IndexedDBMsg_CallbacksUpgradeNeeded_Params params;
   params.ipc_thread_id = ipc_thread_id();
   params.ipc_callbacks_id = ipc_callbacks_id();
   params.ipc_database_id = ipc_database_id;
   params.ipc_database_callbacks_id = ipc_database_callbacks_id_;
   params.old_version = old_version;
   params.idb_metadata = IndexedDBDispatcherHost::ConvertMetadata(metadata);
+  params.data_loss = data_loss;
   dispatcher_host()->Send(new IndexedDBMsg_CallbacksUpgradeNeeded(params));
 }
 
 void IndexedDBCallbacks<WebIDBCursorImpl>::onSuccess(
     WebIDBCursorImpl* idb_cursor,
     const IndexedDBKey& key,
     const IndexedDBKey& primaryKey,
     std::vector<char>* value) {
   int32 ipc_object_id = dispatcher_host()->Add(idb_cursor);
   IndexedDBMsg_CallbacksSuccessIDBCursor_Params params;
@@ skipping 124 matching lines @@
       ipc_thread_id(), ipc_callbacks_id()));
 }
 
 void IndexedDBCallbacks<std::vector<char> >::onSuccess(
     const IndexedDBKey& value) {
   dispatcher_host()->Send(new IndexedDBMsg_CallbacksSuccessIndexedDBKey(
       ipc_thread_id(), ipc_callbacks_id(), value));
 }
 
 }  // namespace content