Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 17033002: HTML parser should not associate elements inside templates with forms (Closed)

Created:
7 years, 6 months ago by adamk
Modified:
7 years, 6 months ago
CC:
blink-reviews, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

HTML parser should not associate elements inside templates with forms When parsing <form><template><input>, the previous behavior was to associate the <input> with the <form>, even though they're not in the same tree (or even the same document!). This patch changes that by checking, prior to creating a form control element, whether the element to be created lives in a document with a browsing context. BUG=247038 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152676

Patch Set 1 #

Patch Set 2 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -1 line) Patch
A LayoutTests/fast/dom/HTMLTemplateElement/no-form-association.html View 1 1 chunk +24 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/HTMLTemplateElement/no-form-association-expected.txt View 1 1 chunk +16 lines, -0 lines 0 comments Download
M Source/core/html/parser/HTMLConstructionSite.cpp View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
abarth-chromium
LGTM
7 years, 6 months ago (2013-06-14 02:03:32 UTC) #1
adamk
+rafaelw I'll be out today and Monday, so if someone would like to land this ...
7 years, 6 months ago (2013-06-14 16:11:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/17033002/4001
7 years, 6 months ago (2013-06-18 20:45:48 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-19 00:03:41 UTC) #4
Message was sent while issue was closed.
Change committed as 152676

Powered by Google App Engine
This is Rietveld 408576698