Remove dependency on GURL from content/common/gpu

content/public/common/content_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_COMMON_CONTENT_CLIENT_H_
 #define CONTENT_PUBLIC_COMMON_CONTENT_CLIENT_H_
 
 #include <set>
 #include <string>
 #include <vector>
 
 #include "base/strings/string16.h"
 #include "base/strings/string_piece.h"
 #include "build/build_config.h"
 #include "content/common/content_export.h"
 #include "ui/base/layout.h"
+#include "url/gurl.h"
 #include "url/url_util.h"
 
-class GURL;
-
 namespace base {
 class RefCountedStaticMemory;
 }
 
 namespace IPC {
 class Message;
 }
 
 namespace gfx {
 class Image;
@@ skipping 40 matching lines @@
   ContentClient();
   virtual ~ContentClient();
 
   ContentBrowserClient* browser() { return browser_; }
   ContentPluginClient* plugin() { return plugin_; }
   ContentRendererClient* renderer() { return renderer_; }
   ContentUtilityClient* utility() { return utility_; }
 
   // Sets the currently active URL.  Use GURL() to clear the URL.
   virtual void SetActiveURL(const GURL& url) {}
+  void SetActiveURL(const std::string& url);

[piman, 2016/02/18 18:29:28]

nit: avoid overloads, especially with one method virtual and the other one not.
SetActiveURLFromString?

OTOH, since gpu_command_buffer_stub.cc is not supposed to access the
ContentClient directly (won't exist in mus), maybe the string->URL conversion
should be in the GpuChildThread (will stay in content/), accessed via the
GpuChannelManagerDelegate that Fady introduces in
https://codereview.chromium.org/1711533002 , so you wouldn't need this here.

[Mark Dittmer, 2016/02/19 14:58:45]

Refactored call into SetActiveURL to plumb through a delegate (same one as in
https://codereview.chromium.org/1711533002/). No more overload.

 
   // Sets the data on the current gpu.
   virtual void SetGpuInfo(const gpu::GPUInfo& gpu_info) {}
 
   // Gives the embedder a chance to register its own pepper plugins.
   virtual void AddPepperPlugins(
       std::vector<content::PepperPluginInfo>* plugins) {}
 
   // Gives the embedder a chance to register its own standard and saveable
   // url schemes early on in the startup sequence.
@@ skipping 72 matching lines @@
   ContentPluginClient* plugin_;
   // The embedder API for participating in renderer logic.
   ContentRendererClient* renderer_;
   // The embedder API for participating in utility logic.
   ContentUtilityClient* utility_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_COMMON_CONTENT_CLIENT_H_