Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 170313004: New kiosk UI: handle edge cases (Closed)

Created:
6 years, 10 months ago by Nikita (slow)
Modified:
6 years, 10 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

New kiosk UI: handle edge cases * Postpone rebuilding user pods layout till account picker screen is shown. * Update [Cancel] button state if user list changes. BUG=334304 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251781

Patch Set 1 #

Total comments: 2

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -16 lines) Patch
M chrome/browser/resources/chromeos/login/header_bar.js View 1 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.js View 1 4 chunks +20 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/login/user_pod_row.js View 5 chunks +35 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nikita (slow)
6 years, 10 months ago (2014-02-18 13:16:31 UTC) #1
dzhioev (left Google)
LGTM with nit. https://codereview.chromium.org/170313004/diff/1/chrome/browser/resources/chromeos/login/screen_gaia_signin.js File chrome/browser/resources/chromeos/login/screen_gaia_signin.js (right): https://codereview.chromium.org/170313004/diff/1/chrome/browser/resources/chromeos/login/screen_gaia_signin.js#newcode77 chrome/browser/resources/chromeos/login/screen_gaia_signin.js:77: * Whether we should user pods ...
6 years, 10 months ago (2014-02-18 14:19:48 UTC) #2
Nikita (slow)
https://codereview.chromium.org/170313004/diff/1/chrome/browser/resources/chromeos/login/screen_gaia_signin.js File chrome/browser/resources/chromeos/login/screen_gaia_signin.js (right): https://codereview.chromium.org/170313004/diff/1/chrome/browser/resources/chromeos/login/screen_gaia_signin.js#newcode77 chrome/browser/resources/chromeos/login/screen_gaia_signin.js:77: * Whether we should user pods on the login ...
6 years, 10 months ago (2014-02-18 14:23:21 UTC) #3
Nikita (slow)
The CQ bit was checked by nkostylev@chromium.org
6 years, 10 months ago (2014-02-18 14:23:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/170313004/70001
6 years, 10 months ago (2014-02-18 14:24:11 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-18 16:42:36 UTC) #6
Message was sent while issue was closed.
Change committed as 251781

Powered by Google App Engine
This is Rietveld 408576698