Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1703113003:
Fix non-Oilpan PassRefPtr<> usage following r375261. (Closed)
DescriptionFix non-Oilpan PassRefPtr<> usage following r375261.
Add required RefPtr<> local bindings of incoming PassRefPtr<>s.
R=haraken
BUG=583376
Committed: https://crrev.com/35cfe759c31844bc76b22780ccdea457af599ef5
Cr-Commit-Position: refs/heads/master@{#376122}
Patch Set 1 #
Messages
Total messages: 16 (8 generated)
Description was changed from ========== Fix non-Oilpan PassRefPtr<> usage following r375261. Add required RefPtr<> local bindings of incoming PassRefPtr<>s. R= BUG=583376 ========== to ========== Fix non-Oilpan PassRefPtr<> usage following r375261. Add required RefPtr<> local bindings of incoming PassRefPtr<>s. TBR=oilpan-reviews BUG=583376 ==========
Description was changed from ========== Fix non-Oilpan PassRefPtr<> usage following r375261. Add required RefPtr<> local bindings of incoming PassRefPtr<>s. TBR=oilpan-reviews BUG=583376 ========== to ========== Fix non-Oilpan PassRefPtr<> usage following r375261. Add required RefPtr<> local bindings of incoming PassRefPtr<>s. R= BUG=583376 ==========
sigbjornf@opera.com changed reviewers: + oilpan-reviews@chromium.org
please take a look. The use of Pass* for the arguments in these various methods & functions can be reduced, but that's a more invasive change in style. Fixed when removing non-Oilpan support.
LGTM
Description was changed from ========== Fix non-Oilpan PassRefPtr<> usage following r375261. Add required RefPtr<> local bindings of incoming PassRefPtr<>s. R= BUG=583376 ========== to ========== Fix non-Oilpan PassRefPtr<> usage following r375261. Add required RefPtr<> local bindings of incoming PassRefPtr<>s. TBR=oilpan-reviews BUG=583376 ==========
Description was changed from ========== Fix non-Oilpan PassRefPtr<> usage following r375261. Add required RefPtr<> local bindings of incoming PassRefPtr<>s. TBR=oilpan-reviews BUG=583376 ========== to ========== Fix non-Oilpan PassRefPtr<> usage following r375261. Add required RefPtr<> local bindings of incoming PassRefPtr<>s. R=haraken BUG=583376 ==========
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1703113003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1703113003/1
Message was sent while issue was closed.
Description was changed from ========== Fix non-Oilpan PassRefPtr<> usage following r375261. Add required RefPtr<> local bindings of incoming PassRefPtr<>s. R=haraken BUG=583376 ========== to ========== Fix non-Oilpan PassRefPtr<> usage following r375261. Add required RefPtr<> local bindings of incoming PassRefPtr<>s. R=haraken BUG=583376 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix non-Oilpan PassRefPtr<> usage following r375261. Add required RefPtr<> local bindings of incoming PassRefPtr<>s. R=haraken BUG=583376 ========== to ========== Fix non-Oilpan PassRefPtr<> usage following r375261. Add required RefPtr<> local bindings of incoming PassRefPtr<>s. R=haraken BUG=583376 Committed: https://crrev.com/35cfe759c31844bc76b22780ccdea457af599ef5 Cr-Commit-Position: refs/heads/master@{#376122} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/35cfe759c31844bc76b22780ccdea457af599ef5 Cr-Commit-Position: refs/heads/master@{#376122}
Message was sent while issue was closed.
I have a quick question here. Is there any documentation of what the correct way of using this pointer is? Is that the case that I always need to pass a PassRefPtr and then cast it to RefPtr in the function or can I directly have a RefPtr in the function parameter?
Message was sent while issue was closed.
On 2016/02/18 15:16:49, Navid Zolghadr wrote: > I have a quick question here. Is there any documentation of what the correct way > of using this pointer is? Is that the case that I always need to pass a > PassRefPtr and then cast it to RefPtr in the function or can I directly have a > RefPtr in the function parameter? Good question re documentation. There used to be WebKit documentation on this (search for "RefPtr basics" or something similar) which spelled out the details and was a useful guide for all, but as WebKit has now moved to using && instead of PassRefPtr<>, that writeup appears hard to locate. Maybe someone has stashed away a copy somewhere.. ? Always use PassRefPtr<> for argument passing over RefPtr<>, but if you end up using it in the body of the method, do bind to a local RefPtr<> first. i.e., just relaying a PassRefPtr<> along to another method is fine without binding it locally.
Message was sent while issue was closed.
http://web.archive.org/web/20150416082146/https://www.webkit.org/coding/RefPt... has a stashed copy. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
