Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 1703103002: [Release] Update ChangeLog file (Closed)

Created:
4 years, 10 months ago by Michael Hablich
Modified:
4 years, 10 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Release] Update ChangeLog file R=machenbach@chromium.org NOTRY=true Committed: https://crrev.com/17468d39306789a2a8b9ab6b60bc80e6cae272e5 Cr-Commit-Position: refs/heads/master@{#34097}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5129 lines, -2 lines) Patch
M ChangeLog View 1 1 chunk +5129 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Michael Hablich
4 years, 10 months ago (2016-02-17 17:44:54 UTC) #1
Michael Achenbach
lgtm https://codereview.chromium.org/1703103002/diff/1/ChangeLog File ChangeLog (right): https://codereview.chromium.org/1703103002/diff/1/ChangeLog#newcode3 ChangeLog:3: The ChangeLog file is no longer maintained on ...
4 years, 10 months ago (2016-02-17 19:27:53 UTC) #2
Michael Hablich
https://codereview.chromium.org/1703103002/diff/1/ChangeLog File ChangeLog (right): https://codereview.chromium.org/1703103002/diff/1/ChangeLog#newcode3 ChangeLog:3: The ChangeLog file is no longer maintained on bleeding_edge. ...
4 years, 10 months ago (2016-02-17 21:27:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1703103002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1703103002/20001
4 years, 10 months ago (2016-02-17 21:27:22 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-17 21:29:02 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 21:29:18 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/17468d39306789a2a8b9ab6b60bc80e6cae272e5
Cr-Commit-Position: refs/heads/master@{#34097}

Powered by Google App Engine
This is Rietveld 408576698