Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1624)

Unified Diff: Source/core/scripts/name_macros.py

Issue 17031006: Rename DOMWindow interface to Window (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase on master Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/scripts/make_event_factory.py ('k') | Source/core/testing/Internals.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/scripts/name_macros.py
diff --git a/Source/core/scripts/name_macros.py b/Source/core/scripts/name_macros.py
index 8af5d28fb9125942f788923faef08b93902acea0..de4927feffdf5e64183c2e9e5fb8776c1ef6ae24 100644
--- a/Source/core/scripts/name_macros.py
+++ b/Source/core/scripts/name_macros.py
@@ -72,6 +72,12 @@ def _name_for_entry(entry):
return entry['interfaceName']
return os.path.basename(entry['name'])
+
+def _js_name_for_entry(entry):
+ if entry['JSInterfaceName']:
+ return entry['JSInterfaceName']
+ return _name_for_entry(entry)
+
class Writer(in_generator.Writer):
def __init__(self, in_file_path, enabled_conditions):
super(Writer, self).__init__(in_file_path, enabled_conditions)
@@ -105,12 +111,12 @@ class Writer(in_generator.Writer):
def _headers_header_include(self, entry):
path = entry['name']
- name = _name_for_entry(entry)
+ js_name = _js_name_for_entry(entry)
if entry['interfaceName']:
path = entry['interfaceName'] # FIXME: This seems wrong
- include = '#include "%(path)s.h"\n#include "V8%(name)s.h"' % {
+ include = '#include "%(path)s.h"\n#include "V8%(js_name)s.h"' % {
'path': path,
- 'name': name,
+ 'js_name': js_name,
}
return self.wrap_with_condition(include, entry['conditional'])
« no previous file with comments | « Source/core/scripts/make_event_factory.py ('k') | Source/core/testing/Internals.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698