Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

Issue 1702913002: Make updates to ChromeVox KB Explorer for Next. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
index 5f0462c36b16502ce8d27084da69a05970374179..ea2ba4aa944ce427f8f086f5d8ab3c61816905b5 100644
--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
@@ -122,8 +122,8 @@ Background = function() {
cvox.ExtensionBridge.addMessageListener(this.onMessage_);
- document.addEventListener('keydown', this.onKeyDown.bind(this), true);
- document.addEventListener('keyup', this.onKeyUp.bind(this), true);
+ document.addEventListener('keydown', this.onKeyDown.bind(this), false);
+ document.addEventListener('keyup', this.onKeyUp.bind(this), false);
cvox.ChromeVoxKbHandler.commandHandler = this.onGotCommand.bind(this);
// Classic keymap.
@@ -536,6 +536,9 @@ Background.prototype = {
case 'increaseTtsVolume':
this.increaseOrDecreaseSpeechProperty_(cvox.AbstractTts.VOLUME, true);
break;
+ case 'stopSpeech':
+ cvox.ChromeVox.tts.stop();
dmazzoni 2016/02/17 04:57:15 Just checking, does this stop continuous reading a
David Tseng 2016/02/17 19:30:11 Set the global.isReading flag to false. It looks l
+ return false;
default:
return true;
}

Powered by Google App Engine
This is Rietveld 408576698