chrome/browser/resources/chromeos/chromevox/chromevox/background/kbexplorer.js - Issue 1702913002: Make updates to ChromeVox KB Explorer for Next.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/chromevox/background/kbexplorer.js

Issue 1702913002: Make updates to ChromeVox KB Explorer for Next. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/accelerators/accelerator_table.cc ('K') | « ash/accelerators/accelerator_table.cc ('k') | chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json » ('j') | chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/chromevox/background/kbexplorer.js

diff --git a/chrome/browser/resources/chromeos/chromevox/chromevox/background/kbexplorer.js b/chrome/browser/resources/chromeos/chromevox/chromevox/background/kbexplorer.js

index 13ed18bae2a7c21cad2eb1a938ccb7e84c3f7ebd..aefdc2628859c41ea3a90a020210428e995695fc 100644

--- a/chrome/browser/resources/chromeos/chromevox/chromevox/background/kbexplorer.js

+++ b/chrome/browser/resources/chromeos/chromevox/chromevox/background/kbexplorer.js

@@ -24,22 +24,19 @@ cvox.KbExplorer = function() { };

cvox.KbExplorer.init = function() {

var backgroundWindow = chrome.extension.getBackgroundPage();

- document.addEventListener('keydown', cvox.KbExplorer.onKeyDown, false);

+ backgroundWindow.addEventListener(

+ 'keydown', cvox.KbExplorer.onKeyDown, true);

+ backgroundWindow.addEventListener('keyup', cvox.KbExplorer.onKeyUp, true);

backgroundWindow.addEventListener(

- 'keydown', cvox.KbExplorer.onKeyDown, false);

- document.addEventListener('keyup', cvox.KbExplorer.onKeyUp, false);

- backgroundWindow.addEventListener('keyup', cvox.KbExplorer.onKeyUp, false);

- document.addEventListener('keypress', cvox.KbExplorer.onKeyPress, false);

- backgroundWindow.addEventListener(

- 'keypress', cvox.KbExplorer.onKeyPress, false);

+ 'keypress', cvox.KbExplorer.onKeyPress, true);

window.onbeforeunload = function(evt) {

backgroundWindow.removeEventListener(

- 'keydown', cvox.KbExplorer.onKeyDown, false);

+ 'keydown', cvox.KbExplorer.onKeyDown, true);

backgroundWindow.removeEventListener(

- 'keyup', cvox.KbExplorer.onKeyUp, false);

+ 'keyup', cvox.KbExplorer.onKeyUp, true);

backgroundWindow.removeEventListener(

- 'keypress', cvox.KbExplorer.onKeyPress, false);

+ 'keypress', cvox.KbExplorer.onKeyPress, true);

};