Make updates to ChromeVox KB Explorer for Next.

Make updates to ChromeVox KB Explorer for Next.

- kbexplorer script now is blacklisted for classic
- we now can actually handle the ctrl key in js (stop speech). Do that. Nicely, this let's us get the ctrl key and speak it in the kbexplorer (it probably just stopped speech in the past, so spoke nothing)
- keys now just go through the background page
- all keys speak

TEST=ChromeVox+o, k. Press some f-keys (back, forward, etc) are read. Press modifiers ctrl, alt, search, shift; verify they are read (queued). Press letters, numbers, shifted keys.
BUG=none

Committed: https://crrev.com/ac594b34f81268de8b1e365e2db4fce4eaeab539
Cr-Commit-Position: refs/heads/master@{#376100}

[David Tseng, 2016-02-17 02:47:46]

Description was changed from

==========
Make updates to ChromeVox KB Explorer for Next.
==========

to

==========
Make updates to ChromeVox KB Explorer for Next.

- kbexplorer script now is blacklisted for classic
- we now can actually handle the ctrl key in js (stop speech). Do that. Nicely,
this let's us get the ctrl key and speak it in the kbexplorer (it probably just
stopped speech in the past, so spoke nothing)
- keys now just go through the background page
- all keys speak
==========

[David Tseng, 2016-02-17 02:47:47]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[David Tseng, 2016-02-17 02:56:18]

Description was changed from

==========
Make updates to ChromeVox KB Explorer for Next.

- kbexplorer script now is blacklisted for classic
- we now can actually handle the ctrl key in js (stop speech). Do that. Nicely,
this let's us get the ctrl key and speak it in the kbexplorer (it probably just
stopped speech in the past, so spoke nothing)
- keys now just go through the background page
- all keys speak
==========

to

==========
Make updates to ChromeVox KB Explorer for Next.

- kbexplorer script now is blacklisted for classic
- we now can actually handle the ctrl key in js (stop speech). Do that. Nicely,
this let's us get the ctrl key and speak it in the kbexplorer (it probably just
stopped speech in the past, so spoke nothing)
- keys now just go through the background page
- all keys speak

TEST=ChromeVox+o, k. Press some f-keys (back, forward, etc) are read. Press
modifiers ctrl, alt, search, shift; verify they are read (queued). Press
letters, numbers, shifted keys.
==========

[dmazzoni, 2016-02-17 04:57:15]

Great!

Could you add showKbExplorerPage to next_keymap as part of this change?

Also, what would you think about making the keyboard explorer open in the Panel?
Not necessarily as part of this change, but that'd look a lot nicer than opening
a mostly empty HTML page in a new tab.

https://codereview.chromium.org/1702913002/diff/1/ash/accelerators/accelerato...
File ash/accelerators/accelerator_table.cc (left):

https://codereview.chromium.org/1702913002/diff/1/ash/accelerators/accelerato...
ash/accelerators/accelerator_table.cc:75: { true, ui::VKEY_CONTROL,
ui::EF_CONTROL_DOWN, SILENCE_SPOKEN_FEEDBACK},
Great! Please remove SILENCE_SPOKEN_FEEDBACK from accelerator_table.h and two
other files that use that enum.

https://codereview.chromium.org/1702913002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
(right):

https://codereview.chromium.org/1702913002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:540:
cvox.ChromeVox.tts.stop();
Just checking, does this stop continuous reading and other things we may be
queuing up based on speech end callbacks?

[David Tseng, 2016-02-17 19:30:11]

https://codereview.chromium.org/1702913002/diff/1/ash/accelerators/accelerato...
File ash/accelerators/accelerator_table.cc (left):

https://codereview.chromium.org/1702913002/diff/1/ash/accelerators/accelerato...
ash/accelerators/accelerator_table.cc:75: { true, ui::VKEY_CONTROL,
ui::EF_CONTROL_DOWN, SILENCE_SPOKEN_FEEDBACK},
On 2016/02/17 04:57:15, dmazzoni wrote:
> Great! Please remove SILENCE_SPOKEN_FEEDBACK from accelerator_table.h and two
> other files that use that enum.

Done.

https://codereview.chromium.org/1702913002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
(right):

https://codereview.chromium.org/1702913002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:540:
cvox.ChromeVox.tts.stop();
On 2016/02/17 04:57:15, dmazzoni wrote:
> Just checking, does this stop continuous reading and other things we may be
> queuing up based on speech end callbacks?

Set the global.isReading flag to false. It looks like it does stop continuous
read, but the flag isn't reset.

[dmazzoni, 2016-02-17 20:13:49]

lgtm

https://codereview.chromium.org/1702913002/diff/40001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/chromevox/background/kbexplorer.js
(right):

https://codereview.chromium.org/1702913002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/chromevox/background/kbexplorer.js:27:
backgroundWindow.addEventListener(
nit: indentation

[David Tseng, 2016-02-17 20:21:41]

dtseng@chromium.org changed reviewers:
+ oshima@chromium.org

[David Tseng, 2016-02-17 20:21:42]

+ oshima for ash/accelerators/

https://codereview.chromium.org/1702913002/diff/40001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/chromevox/background/kbexplorer.js
(right):

https://codereview.chromium.org/1702913002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/chromevox/background/kbexplorer.js:27:
backgroundWindow.addEventListener(
On 2016/02/17 20:13:49, dmazzoni wrote:
> nit: indentation

Done.

[David Tseng, 2016-02-17 20:22:05]

Patchset #2 (id:20001) has been deleted

[oshima, 2016-02-18 03:52:29]

On 2016/02/17 20:21:42, David Tseng wrote:
> + oshima for ash/accelerators/
> 
>
https://codereview.chromium.org/1702913002/diff/40001/chrome/browser/resource...
> File
> chrome/browser/resources/chromeos/chromevox/chromevox/background/kbexplorer.js
> (right):
> 
>
https://codereview.chromium.org/1702913002/diff/40001/chrome/browser/resource...
>
chrome/browser/resources/chromeos/chromevox/chromevox/background/kbexplorer.js:27:
> backgroundWindow.addEventListener(
> On 2016/02/17 20:13:49, dmazzoni wrote:
> > nit: indentation
> 
> Done.

ash/accelerators lgtm.
one nit: do you have bug for this? If not, BUG=None.

[David Tseng, 2016-02-18 04:22:25]

On 2016/02/18 03:52:29, oshima (OOO Feb 16-18) wrote:
> On 2016/02/17 20:21:42, David Tseng wrote:
> > + oshima for ash/accelerators/
> > 
> >
>
https://codereview.chromium.org/1702913002/diff/40001/chrome/browser/resource...
> > File
> >
chrome/browser/resources/chromeos/chromevox/chromevox/background/kbexplorer.js
> > (right):
> > 
> >
>
https://codereview.chromium.org/1702913002/diff/40001/chrome/browser/resource...
> >
>
chrome/browser/resources/chromeos/chromevox/chromevox/background/kbexplorer.js:27:
> > backgroundWindow.addEventListener(
> > On 2016/02/17 20:13:49, dmazzoni wrote:
> > > nit: indentation
> > 
> > Done.
> 
> ash/accelerators lgtm.
> one nit: do you have bug for this? If not, BUG=None.

Done.

[David Tseng, 2016-02-18 04:22:41]

Description was changed from

==========
Make updates to ChromeVox KB Explorer for Next.

- kbexplorer script now is blacklisted for classic
- we now can actually handle the ctrl key in js (stop speech). Do that. Nicely,
this let's us get the ctrl key and speak it in the kbexplorer (it probably just
stopped speech in the past, so spoke nothing)
- keys now just go through the background page
- all keys speak

TEST=ChromeVox+o, k. Press some f-keys (back, forward, etc) are read. Press
modifiers ctrl, alt, search, shift; verify they are read (queued). Press
letters, numbers, shifted keys.
==========

to

==========
Make updates to ChromeVox KB Explorer for Next.

- kbexplorer script now is blacklisted for classic
- we now can actually handle the ctrl key in js (stop speech). Do that. Nicely,
this let's us get the ctrl key and speak it in the kbexplorer (it probably just
stopped speech in the past, so spoke nothing)
- keys now just go through the background page
- all keys speak

TEST=ChromeVox+o, k. Press some f-keys (back, forward, etc) are read. Press
modifiers ctrl, alt, search, shift; verify they are read (queued). Press
letters, numbers, shifted keys.
BUG=none
==========

[David Tseng, 2016-02-18 04:23:00]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-02-18 04:23:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/1702913002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-02-18 04:23:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1702913002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1702913002/60001

[commit-bot: I haz the power, 2016-02-18 04:26:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-18 04:26:14]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[David Tseng, 2016-02-18 04:31:51]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-02-18 04:31:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org, oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/1702913002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2016-02-18 04:33:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1702913002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1702913002/80001

[commit-bot: I haz the power, 2016-02-18 05:21:17]

Description was changed from

==========
Make updates to ChromeVox KB Explorer for Next.

- kbexplorer script now is blacklisted for classic
- we now can actually handle the ctrl key in js (stop speech). Do that. Nicely,
this let's us get the ctrl key and speak it in the kbexplorer (it probably just
stopped speech in the past, so spoke nothing)
- keys now just go through the background page
- all keys speak

TEST=ChromeVox+o, k. Press some f-keys (back, forward, etc) are read. Press
modifiers ctrl, alt, search, shift; verify they are read (queued). Press
letters, numbers, shifted keys.
BUG=none
==========

to

==========
Make updates to ChromeVox KB Explorer for Next.

- kbexplorer script now is blacklisted for classic
- we now can actually handle the ctrl key in js (stop speech). Do that. Nicely,
this let's us get the ctrl key and speak it in the kbexplorer (it probably just
stopped speech in the past, so spoke nothing)
- keys now just go through the background page
- all keys speak

TEST=ChromeVox+o, k. Press some f-keys (back, forward, etc) are read. Press
modifiers ctrl, alt, search, shift; verify they are read (queued). Press
letters, numbers, shifted keys.
BUG=none
==========

[commit-bot: I haz the power, 2016-02-18 05:21:18]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-02-18 05:22:53]

Description was changed from

==========
Make updates to ChromeVox KB Explorer for Next.

- kbexplorer script now is blacklisted for classic
- we now can actually handle the ctrl key in js (stop speech). Do that. Nicely,
this let's us get the ctrl key and speak it in the kbexplorer (it probably just
stopped speech in the past, so spoke nothing)
- keys now just go through the background page
- all keys speak

TEST=ChromeVox+o, k. Press some f-keys (back, forward, etc) are read. Press
modifiers ctrl, alt, search, shift; verify they are read (queued). Press
letters, numbers, shifted keys.
BUG=none
==========

to

==========
Make updates to ChromeVox KB Explorer for Next.

- kbexplorer script now is blacklisted for classic
- we now can actually handle the ctrl key in js (stop speech). Do that. Nicely,
this let's us get the ctrl key and speak it in the kbexplorer (it probably just
stopped speech in the past, so spoke nothing)
- keys now just go through the background page
- all keys speak

TEST=ChromeVox+o, k. Press some f-keys (back, forward, etc) are read. Press
modifiers ctrl, alt, search, shift; verify they are read (queued). Press
letters, numbers, shifted keys.
BUG=none

Committed: https://crrev.com/ac594b34f81268de8b1e365e2db4fce4eaeab539
Cr-Commit-Position: refs/heads/master@{#376100}
==========

[commit-bot: I haz the power, 2016-02-18 05:22:54]

Patchset 4 (id:??) landed as
https://crrev.com/ac594b34f81268de8b1e365e2db4fce4eaeab539
Cr-Commit-Position: refs/heads/master@{#376100}