ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h - Issue 17029020: linux_aura: Redo how memory is handled in clipboard/drag code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h

Issue 17029020: linux_aura: Redo how memory is handled in clipboard/drag code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixes for sky; ptal Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h

diff --git a/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h b/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h

index 4152778d0b6c848cc6361263e242a5618b5222a4..47b820617581a17c7550bb2de77730b6afff44ad 100644

--- a/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h

+++ b/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h

@@ -128,10 +128,10 @@ class VIEWS_EXPORT DesktopDragDropClientAuraX11

// processes.

std::vector< ::Atom> GetOfferedDragOperations();

- // This returns a newly allocated copy of the data we're offering in this

+ // This returns a representation of the data we're offering in this

// drag. This is done to bypass an asynchronous roundtrip with the X11

// server.

- scoped_ptr<ui::SelectionFormatMap> CloneFormatMap() const;

+ ui::SelectionFormatMap GetFormatMap() const;

// Handling XdndPosition can be paused while waiting for more data; this is

// called either synchronously from OnXdndPosition, or asynchronously after