Issue 17029016: Remove DRT-specific resource loading logic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17029016: Remove DRT-specific resource loading logic (Closed)

Created:
7 years, 6 months ago by jamesr

Modified:
7 years, 5 months ago

Reviewers:
Dirk Pranke, dpranke

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove DRT-specific resource loading logic This logic was used by DumpRenderTree, which is dead. These classes are still used by webkit_unit_tests, but the unit tests don't require resource loading. R=dpranke

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -554 lines)			Patch
D	webkit/support/platform_support.h	View	1 chunk	+0 lines, -22 lines	0 comments	Download
D	webkit/support/platform_support_android.cc	View	1 chunk	+0 lines, -102 lines	0 comments	Download
D	webkit/support/platform_support_linux.cc	View	1 chunk	+0 lines, -76 lines	0 comments	Download
D	webkit/support/platform_support_mac.mm	View	1 chunk	+0 lines, -207 lines	0 comments	Download
D	webkit/support/platform_support_win.cc	View	1 chunk	+0 lines, -115 lines	0 comments	Download
M	webkit/support/test_webkit_platform_support.cc	View	4 chunks	+14 lines, -3 lines	0 comments	Download
M	webkit/support/webkit_support.cc	View	3 chunks	+0 lines, -5 lines	0 comments	Download
M	webkit/support/webkit_support.gypi	View	2 chunks	+0 lines, -24 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/17029016/1

7 years, 6 months ago (2013-06-21 20:45:34 UTC) #3

jamesr

7 years, 6 months ago (2013-06-21 22:09:23 UTC) #4

D'oh, some of the setup code on mac / android is still needed by webkit_unit
tests.

Expand Messages | Collapse Messages