Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1702853002: [cleanup] add Parser accessors for FLAG_harmony_function_sent (Closed)

Created:
4 years, 10 months ago by caitp (gmail)
Modified:
4 years, 10 months ago
Reviewers:
Dan Ehrenberg, adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cleanup] add Parser accessors for FLAG_harmony_function_sent BUG= LOG=N R=adamk@chromium.org, littledan@chromium.org Committed: https://crrev.com/3649170259abda3261d210bcde2a444991da4e4d Cr-Commit-Position: refs/heads/master@{#34051}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M src/parsing/parser.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/parsing/parser-base.h View 4 chunks +5 lines, -2 lines 0 comments Download
M test/cctest/test-parsing.cc View 4 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
caitp (gmail)
PTAL, cleanup post-https://codereview.chromium.org/1700123003/
4 years, 10 months ago (2016-02-16 23:39:36 UTC) #1
adamk
lgtm, thanks for the cleanup
4 years, 10 months ago (2016-02-16 23:46:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1702853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1702853002/1
4 years, 10 months ago (2016-02-16 23:47:07 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-17 00:18:45 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 00:19:28 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3649170259abda3261d210bcde2a444991da4e4d
Cr-Commit-Position: refs/heads/master@{#34051}

Powered by Google App Engine
This is Rietveld 408576698