Source/core/css/MediaQueryEvaluator.h - Issue 170283019: Change various helper classes to transition types to get CSSValue entirely onto the gc heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/MediaQueryEvaluator.h

Issue 170283019: Change various helper classes to transition types to get CSSValue entirely onto the gc heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase and revert member to persistent in StorageEvent Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/MediaQueryEvaluator.h

diff --git a/Source/core/css/MediaQueryEvaluator.h b/Source/core/css/MediaQueryEvaluator.h

index 6b742ee428ece4f841785ed847400100994259fc..1a03b799960ff3e27e8c8279767bd36a15d2dea7 100644

--- a/Source/core/css/MediaQueryEvaluator.h

+++ b/Source/core/css/MediaQueryEvaluator.h

@@ -28,6 +28,7 @@

#ifndef MediaQueryEvaluator_h

#define MediaQueryEvaluator_h

+#include "heap/Handle.h"

#include "wtf/text/WTFString.h"

namespace WebCore {

@@ -37,7 +38,7 @@ class MediaQueryResult;

class MediaQuerySet;

class RenderStyle;

-typedef Vector<RefPtr<MediaQueryResult> > MediaQueryResultList;

+typedef WillBePersistentHeapVector<RefPtrWillBeMember<MediaQueryResult> > MediaQueryResultList;

zerny-chromium 2014/03/05 06:38:40 Maybe this should be expanded at the use sites. It

wibling-chromium 2014/03/05 08:09:42 Agree. I will fix this is a subsequent change to n

/**

* Class that evaluates css media queries as defined in

« Source/core/css/MediaList.h ('K') | « Source/core/css/MediaQuery.cpp ('k') | Source/core/css/MediaQueryEvaluator.cpp » ('j') | no next file with comments »