Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: Source/core/css/CSSGrammar.y

Issue 170283019: Change various helper classes to transition types to get CSSValue entirely onto the gc heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase and revert member to persistent in StorageEvent Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/css/CSSImportRule.h » ('j') | Source/core/css/MediaList.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/CSSGrammar.y
diff --git a/Source/core/css/CSSGrammar.y b/Source/core/css/CSSGrammar.y
index 65c24613abe1b07027e56cbd26936cae5ba40c44..b1e315fc4589cea52ee80f8343ce28301e08f7e8 100644
--- a/Source/core/css/CSSGrammar.y
+++ b/Source/core/css/CSSGrammar.y
@@ -73,8 +73,10 @@ using namespace HTMLNames;
CSSParserString string;
StyleRuleBase* rule;
- // Vector pointed to by raw ruleList pointer is guaranteed to be kept alive by the BisonCSSParser::m_parsedRules vector.
+ // The content of the two below HeapVectors are guaranteed to be kept alive by
+ // the corresponding m_parsedRules and m_floatingMediaQueryExpList lists in BisonCSSParser.h.
WillBeHeapVector<RefPtrWillBeMember<StyleRuleBase> >* ruleList;
+ WillBeHeapVector<OwnPtrWillBeMember<MediaQueryExp> >* mediaQueryExpList;
CSSParserSelector* selector;
Vector<OwnPtr<CSSParserSelector> >* selectorList;
CSSSelector::MarginBoxType marginBox;
@@ -85,7 +87,6 @@ using namespace HTMLNames;
MediaQueryExp* mediaQueryExp;
CSSParserValue value;
CSSParserValueList* valueList;
- Vector<OwnPtr<MediaQueryExp> >* mediaQueryExpList;
StyleKeyframe* keyframe;
Vector<RefPtr<StyleKeyframe> >* keyframeRuleList;
float val;
« no previous file with comments | « no previous file | Source/core/css/CSSImportRule.h » ('j') | Source/core/css/MediaList.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698