Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Side by Side Diff: Source/core/css/CSSGrammar.y

Issue 170283019: Change various helper classes to transition types to get CSSValue entirely onto the gc heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Review feedback Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/css/CSSImportRule.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 %{ 1 %{
2 2
3 /* 3 /*
4 * Copyright (C) 2002-2003 Lars Knoll (knoll@kde.org) 4 * Copyright (C) 2002-2003 Lars Knoll (knoll@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 App le Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 App le Inc. All rights reserved.
6 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2008 Eric Seidel <eric@webkit.org> 7 * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
8 * Copyright (C) 2012 Intel Corporation. All rights reserved. 8 * Copyright (C) 2012 Intel Corporation. All rights reserved.
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 CSSParserSelector* selector; 78 CSSParserSelector* selector;
79 Vector<OwnPtr<CSSParserSelector> >* selectorList; 79 Vector<OwnPtr<CSSParserSelector> >* selectorList;
80 CSSSelector::MarginBoxType marginBox; 80 CSSSelector::MarginBoxType marginBox;
81 CSSSelector::Relation relation; 81 CSSSelector::Relation relation;
82 MediaQuerySet* mediaList; 82 MediaQuerySet* mediaList;
83 MediaQuery* mediaQuery; 83 MediaQuery* mediaQuery;
84 MediaQuery::Restrictor mediaQueryRestrictor; 84 MediaQuery::Restrictor mediaQueryRestrictor;
85 MediaQueryExp* mediaQueryExp; 85 MediaQueryExp* mediaQueryExp;
86 CSSParserValue value; 86 CSSParserValue value;
87 CSSParserValueList* valueList; 87 CSSParserValueList* valueList;
88 Vector<OwnPtr<MediaQueryExp> >* mediaQueryExpList; 88 WillBeHeapVector<OwnPtrWillBeMember<MediaQueryExp> >* mediaQueryExpList;
Mads Ager (chromium) 2014/03/03 11:30:21 As with the ruleList above, I guess there is somet
wibling-chromium 2014/03/03 11:40:17 I will group it with the above StyleRuleBase vecto
89 StyleKeyframe* keyframe; 89 StyleKeyframe* keyframe;
90 Vector<RefPtr<StyleKeyframe> >* keyframeRuleList; 90 Vector<RefPtr<StyleKeyframe> >* keyframeRuleList;
91 float val; 91 float val;
92 CSSPropertyID id; 92 CSSPropertyID id;
93 CSSParserLocation location; 93 CSSParserLocation location;
94 } 94 }
95 95
96 %{ 96 %{
97 97
98 static inline int cssyyerror(void*, const char*) 98 static inline int cssyyerror(void*, const char*)
(...skipping 1797 matching lines...) Expand 10 before | Expand all | Expand 10 after
1896 1896
1897 rule_error_recovery: 1897 rule_error_recovery:
1898 /* empty */ 1898 /* empty */
1899 | rule_error_recovery error 1899 | rule_error_recovery error
1900 | rule_error_recovery invalid_square_brackets_block 1900 | rule_error_recovery invalid_square_brackets_block
1901 | rule_error_recovery invalid_parentheses_block 1901 | rule_error_recovery invalid_parentheses_block
1902 ; 1902 ;
1903 1903
1904 %% 1904 %%
1905 1905
OLDNEW
« no previous file with comments | « no previous file | Source/core/css/CSSImportRule.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698