Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: Source/core/storage/StorageEvent.h

Issue 170283019: Change various helper classes to transition types to get CSSValue entirely onto the gc heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed incorrect persistent found by the clang oilpan plugin Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2008, 2009 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 72
73 private: 73 private:
74 StorageEvent(); 74 StorageEvent();
75 StorageEvent(const AtomicString& type, const String& key, const String& oldV alue, const String& newValue, const String& url, Storage* storageArea); 75 StorageEvent(const AtomicString& type, const String& key, const String& oldV alue, const String& newValue, const String& url, Storage* storageArea);
76 StorageEvent(const AtomicString&, const StorageEventInit&); 76 StorageEvent(const AtomicString&, const StorageEventInit&);
77 77
78 String m_key; 78 String m_key;
79 String m_oldValue; 79 String m_oldValue;
80 String m_newValue; 80 String m_newValue;
81 String m_url; 81 String m_url;
82 RefPtrWillBePersistent<Storage> m_storageArea; 82 RefPtrWillBeMember<Storage> m_storageArea;
haraken 2014/03/03 10:51:30 Event might be reverted to RefCounted<Event> soon
wibling-chromium 2014/03/03 11:21:11 Yes, I know, but it seemed better to me to fix it
83 }; 83 };
84 84
85 } // namespace WebCore 85 } // namespace WebCore
86 86
87 #endif // StorageEvent_h 87 #endif // StorageEvent_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698