Change various helper classes to transition types to get CSSValue entirely onto the gc heap.

Source/core/css/MediaQueryExp.cpp

 /*
  * CSS Media Query
  *
  * Copyright (C) 2006 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
  * Copyright (C) 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
@@ skipping 20 matching lines @@
 #include "core/css/MediaQueryExp.h"
 
 #include "CSSValueKeywords.h"
 #include "core/css/CSSAspectRatioValue.h"
 #include "core/css/parser/BisonCSSParser.h"
 #include "core/css/CSSPrimitiveValue.h"
 #include "wtf/text/StringBuilder.h"
 
 namespace WebCore {
 
+DEFINE_GC_INFO(MediaQueryExp);
+
 static inline bool featureWithCSSValueID(const AtomicString& mediaFeature, const CSSParserValue* value)
 {
     if (!value->id)
         return false;
 
     return mediaFeature == MediaFeatureNames::orientationMediaFeature
         || mediaFeature == MediaFeatureNames::viewModeMediaFeature
         || mediaFeature == MediaFeatureNames::pointerMediaFeature
         || mediaFeature == MediaFeatureNames::scanMediaFeature;
 }
@@ skipping 137 matching lines @@
         || m_mediaFeature == MediaFeatureNames::maxWidthMediaFeature
         || m_mediaFeature == MediaFeatureNames::maxHeightMediaFeature
         || m_mediaFeature == MediaFeatureNames::orientationMediaFeature
         || m_mediaFeature == MediaFeatureNames::aspectRatioMediaFeature
         || m_mediaFeature == MediaFeatureNames::minAspectRatioMediaFeature
         || m_mediaFeature == MediaFeatureNames::devicePixelRatioMediaFeature
         || m_mediaFeature == MediaFeatureNames::resolutionMediaFeature
         || m_mediaFeature == MediaFeatureNames::maxAspectRatioMediaFeature;
 }
 
+MediaQueryExp::MediaQueryExp(const MediaQueryExp& other)

[haraken, 2014/02/21 01:02:36]

I'm just curious: Why do you need to add the copy constructor?

[wibling-chromium, 2014/02/21 08:43:08]

Because of the copy method in the .h file. It call MediaQueryExp(*this) and the
implicit/default copy constructor is deleted in the GarbageCollected parent.

+    : m_mediaFeature(other.mediaFeature())
+    , m_value(other.value())
+{
+}
+
 MediaQueryExp::MediaQueryExp(const AtomicString& mediaFeature, PassRefPtrWillBeRawPtr<CSSValue> value)
     : m_mediaFeature(mediaFeature)
     , m_value(value)
 {
 }
 
-PassOwnPtr<MediaQueryExp> MediaQueryExp::create(const AtomicString& mediaFeature, CSSParserValueList* valueList)
+PassOwnPtrWillBeRawPtr<MediaQueryExp> MediaQueryExp::create(const AtomicString& mediaFeature, CSSParserValueList* valueList)
 {
     RefPtrWillBeRawPtr<CSSValue> cssValue;
     bool isValid = false;
 
     // Create value for media query expression that must have 1 or more values.
     if (valueList) {
         if (valueList->size() == 1) {
             CSSParserValue* value = valueList->current();
 
             if (featureWithCSSValueID(mediaFeature, value)) {
@@ skipping 46 matching lines @@
             if (isValid)
                 cssValue = CSSAspectRatioValue::create(numeratorValue, denominatorValue);
         }
     } else if (featureWithoutValue(mediaFeature)) {
         isValid = true;
     }
 
     if (!isValid)
         return nullptr;
 
-    return adoptPtr(new MediaQueryExp(mediaFeature, cssValue));
+    return adoptPtrWillBeNoop(new MediaQueryExp(mediaFeature, cssValue));
 }
 
 MediaQueryExp::~MediaQueryExp()
 {
 }
 
 String MediaQueryExp::serialize() const
 {
     StringBuilder result;
     result.append("(");
     result.append(m_mediaFeature.lower());
     if (m_value) {
         result.append(": ");
         result.append(m_value->cssText());
     }
     result.append(")");
 
     return result.toString();
 }
 
 } // namespace