Issue 170283009: Revert of Cast: Added a EncodingEventSubscriber to cast sender app.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 170283009: Revert of Cast: Added a EncodingEventSubscriber to cast sender app. (Closed)

Created:
6 years, 10 months ago by Lei Zhang

Modified:
6 years, 10 months ago

Reviewers:
imcheng, Alpha Left Google

CC:
chromium-reviews, hclam+watch_chromium.org, mikhal+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, pwestin+watch_google.com, feature-media-reviews_chromium.org, hubbe+watch_chromium.org, miu+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@encoding-event-subscriber

Visibility:
Public.

More Reviews

Description

Revert of Cast: Added a EncodingEventSubscriber to cast sender app. (https://codereview.chromium.org/162103002/) Reason for revert: Broke 32 bit bots, printf() usage is non-portable. Original issue's description: > Cast: Added a EncodingEventSubscriber to cast sender app. > > - Logs encoded uncompressed raw events for the first X seconds to a file path Y, where X and Y > can be specified by the user. > - Also outputs some basic stats. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251972 TBR=hclam@chromium.org,imcheng@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251980

Patch Set 1 #

Created: 6 years, 10 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -182 lines)			Patch
M	media/cast/cast.gyp	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	media/cast/test/receiver.cc	View	2 chunks	+3 lines, -6 lines	0 comments	Download
M	media/cast/test/sender.cc	View	8 chunks	+2 lines, -172 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

Created Revert of Cast: Added a EncodingEventSubscriber to cast sender app.

6 years, 10 months ago (2014-02-19 06:52:20 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/170283009/1

6 years, 10 months ago (2014-02-19 06:52:36 UTC) #2

Message was sent while issue was closed.

Change committed as 251980

Expand Messages | Collapse Messages