Issue 170283008: [cc] Modify TestNextActionBeginsMainFrameIfNeeded

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 170283008: [cc] Modify TestNextActionBeginsMainFrameIfNeeded (Closed)

Created:
6 years, 10 months ago by simonhong

Modified:
6 years, 10 months ago

Reviewers:
brianderson

CC:
chromium-reviews, cc-bugs_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[cc] Modify TestNextActionBeginsMainFrameIfNeeded In the second and third test of TestNextActionsBeginsMainFrameIfNeeded, they test when commit is requested. But, both tests doesn't set commit is needed. Also, third test should check whether next action is BEGIN_MAIN_FRAME or not. R=brianderson@chromium.org BUG=NONE TEST=cc_unittests --gtest_filter=*.TestNextActionBeginsMainFrameIfNeeded Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252144

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	M	cc/scheduler/scheduler_state_machine_unittest.cc	View		2 chunks	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

brianderson

lgtm. Thanks for making sure the tests are testing what they are trying to test.

6 years, 10 months ago (2014-02-19 18:17:34 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhong@chromium.org/170283008/1

6 years, 10 months ago (2014-02-19 19:38:47 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhong@chromium.org/170283008/1

6 years, 10 months ago (2014-02-20 00:14:55 UTC) #5

Message was sent while issue was closed.

Change committed as 252144

Expand Messages | Collapse Messages