Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 17028014: Disallow explicit scoped_ptr<T> construction from NULL. (Closed)

Created:
7 years, 6 months ago by dcheng
Modified:
7 years, 6 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org
Visibility:
Public.

Description

Disallow explicit scoped_ptr<T> construction from NULL. This matches the behavior of std::unique_ptr<T>, which is the long-term replacement for scoped_ptr<T>. BUG=173286 R=jyasskin@chromium.org, mark@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208773

Patch Set 1 #

Patch Set 2 : Temporary patch with fixes #

Patch Set 3 : Temp patch 2 #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M base/memory/scoped_ptr.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dcheng
Hopefully this can land sometime this weekend... Linux/ChromeOS/Mac should be more or less fixed at ...
7 years, 6 months ago (2013-06-14 14:48:21 UTC) #1
dcheng
As it turns out, this is blocked on at least one third_party library, and I ...
7 years, 6 months ago (2013-06-14 15:20:08 UTC) #2
dcheng
Ping. Mind taking another look now that (almost) all instances have been fixed?
7 years, 6 months ago (2013-06-26 18:02:15 UTC) #3
Jeffrey Yasskin
lgtm if all the trybots build happily.
7 years, 6 months ago (2013-06-26 18:13:42 UTC) #4
Mark Mentovai
LGTM
7 years, 6 months ago (2013-06-26 20:24:28 UTC) #5
dcheng
7 years, 6 months ago (2013-06-26 20:29:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 manually as r208773 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698