sdk/lib/_internal/compiler/implementation/ssa/tracer.dart - Issue 17028011: Implement a list tracer phase, that tries to find element types in individual lists.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/tracer.dart

Issue 17028011: Implement a list tracer phase, that tries to find element types in individual lists. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart ('k') | sdk/lib/_internal/compiler/implementation/types/container_tracer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/tracer.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/ssa/tracer.dart (revision 24023)

+++ sdk/lib/_internal/compiler/implementation/ssa/tracer.dart (working copy)

@@ -179,12 +179,18 @@

String temporaryId(HInstruction instruction) {

String prefix;

HType type = instruction.instructionType;

- if (type.isMutableArray(compiler)) {

+ if (type.isExtendableArray(compiler)) {

+ prefix = 'e';

+ } else if (type.isFixedArray(compiler)) {

+ prefix = 'f';

+ } else if (type.isMutableArray(compiler)) {

prefix = 'm';

} else if (type.isReadableArray(compiler)) {

prefix = 'a';

- } else if (type.isExtendableArray(compiler)) {

- prefix = 'e';

+ } else if (type.isString(compiler)) {

+ prefix = 's';

+ } else if (type.isIndexable(compiler)) {

+ prefix = 'r';

} else if (type == HType.BOOLEAN) {

prefix = 'b';

} else if (type == HType.INTEGER) {

@@ -193,14 +199,10 @@

prefix = 'd';

} else if (type == HType.NUMBER) {

prefix = 'n';

- } else if (type.isString(compiler)) {

- prefix = 's';

} else if (type == HType.UNKNOWN) {

prefix = 'v';

} else if (type == HType.CONFLICTING) {

prefix = 'c';

- } else if (type.isIndexable(compiler)) {

- prefix = 'r';

} else if (type == HType.NULL) {

prefix = 'u';

} else {