LINE_INFO, TOKEN_STREAM access cleanup.

LINE_INFO, TOKEN_STREAM access cleanup.

Rather than gratituitously re-scan, declare LINE_INFO and PARSED_UNIT as task inputs.

See: https://codereview.chromium.org/1702733002/diff/1/pkg/analyzer/lib/src/task/dart.dart for more context.

BUG=
R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/56a9c0d9f1ea1e5d86a4571d413f6c199dd19937

[pquitslund, 2016-02-17 04:52:16]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com

[pquitslund, 2016-02-17 04:52:16]

Here's the suggested refinement.  I'm curious how this will work in the presence
of summaries...  Any concerns?

[Brian Wilkerson, 2016-02-17 14:49:58]

LGTM

> I'm curious how this will work in the presence of summaries...  Any concerns?

Nope. When the element model is re-created from a summary and we end up needing
to run this task, it will force us to scan and parse the AST, but we will have
needed to do that anyway because summaries (as far as I know) don't store
errors. So to have any errors to filter we will have already scanned, parsed and
resolved the AST.

[pquitslund, 2016-02-17 16:29:23]

Great!  Thanks for the confirmation.

[pquitslund, 2016-02-17 16:30:30]

Description was changed from

==========
LINE_INFO, TOKEN_STREAM access cleanup.

Rather than gratituitously re-scan, declare LINE_INFO and PARSED_UNIT as task
inputs.

See:
https://codereview.chromium.org/1702733002/diff/1/pkg/analyzer/lib/src/task/d...
for more context.

BUG=
==========

to

==========
LINE_INFO, TOKEN_STREAM access cleanup.

Rather than gratituitously re-scan, declare LINE_INFO and PARSED_UNIT as task
inputs.

See:
https://codereview.chromium.org/1702733002/diff/1/pkg/analyzer/lib/src/task/d...
for more context.

BUG=
R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/56a9c0d9f1ea1e5d86a4571d413f6c199dd19937
==========

[pquitslund, 2016-02-17 16:30:32]

Committed patchset #1 (id:1) manually as
56a9c0d9f1ea1e5d86a4571d413f6c199dd19937 (presubmit successful).