DevTools: Implement extensions-based shortcut bindings

Source/devtools/front_end/modules.js

 /*
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  * 1. Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *
@@ skipping 13 matching lines @@
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 /**
  * @type {!Array.<!WebInspector.ModuleManager.ModuleDescriptor>}
  */
 var allDescriptors = [
     {
+        name: "core",
+        extensions: [
+            {
+                type: "@WebInspector.ActionDelegate",
+                bindings: [

[pfeldman, 2014/02/21 16:29:16]

What about mac shortcuts? F5 should do what Cmd+R does.

shodtcuts: {
    mac: "Cmd+r",
    nonmac: "F5,Ctrl+R"
}

Then you use modifiers on the event to choose between the options (reload
with(out) cache, breakpoints, etc.)

[apavlov, 2014/02/24 09:57:57]

Not quite. As per the current code, CtrlOrCmd+R reloads the page skipping all
breakpoints. See the "CtrlOrMeta+R" shortcut and its action below.
This approach does not seem flexible enough, since we may need alternative
shortcuts for Windows (panel history traversal in InspectorView), that's why I
made the shortcuts per-platform (platforms can be delimited by commas in the
list, btw)
Right, but the Ctrl+R and F5 behaviors seem different (breakpoint skipping)
enough to have distinct actions for these shortcuts.

[pfeldman, 2014/03/13 05:24:02]

Ctrl+R vs F5 behaving differently is just an oversight.
As for platforms, you scheme would be fine (thought too verbose to my taste), if
it was not using logical expressions ("!mac").

[apavlov, 2014/03/17 13:40:59]

Unified the behavior and removed logical expressions, so that the platforms now
should be listed explicitly.

+                    {
+                        platform: "!mac",
+                        shortcut: "F5"
+                    },
+                    {
+                        platform: "!mac",
+                        shortcut: "Shift+F5"
+                    },
+                    {
+                        platform: "!mac",
+                        shortcut: "Ctrl+F5"
+                    }
+                ],
+                className: "WebInspector.ResourceTreeModel.ReloadPageActionDelegate"
+            },
+            {
+                type: "@WebInspector.ActionDelegate",
+                bindings: [
+                    {
+                        shortcut: "Esc"
+                    }
+                ],
+                className: "WebInspector.InspectorView.DrawerToggleActionDelegate"
+            },
+            {
+                type: "@WebInspector.ActionDelegate",
+                bindings: [
+                    {
+                        shortcut: "Ctrl+`"
+                    }
+                ],
+                className: "WebInspector.InspectorView.ShowConsoleActionDelegate"
+            },
+            {
+                type: "@WebInspector.ActionDelegate",
+                bindings: [
+                    {
+                        shortcut: "CtrlOrMeta+R"
+                    }
+                ],
+                className: "WebInspector.SkipAllPausesAndReloadActionDelegate"
+            },
+            {
+                type: "@WebInspector.ActionDelegate",
+                bindings: [
+                    {
+                        shortcut: "Alt+R"
+                    }
+                ],
+                className: "WebInspector.DebugReloadActionDelegate"
+            }
+        ]
+    },
+    {
         name: "elements",
         extensions: [
             {
                 type: "@WebInspector.Panel",
                 name: "elements",
                 title: "Elements",
                 order: 0,
                 className: "WebInspector.ElementsPanel"
             },
             {
@@ skipping 90 matching lines @@
                 type: "@WebInspector.Drawer.ViewFactory",
                 name: "search",
                 title: "Search",
                 order: "1",
                 className: "WebInspector.AdvancedSearchController.ViewFactory"
             },
             {
                 type: "@WebInspector.Revealer",
                 contextTypes: ["WebInspector.UILocation"],
                 className: "WebInspector.SourcesPanel.UILocationRevealer"
+            },
+            {
+                type: "@WebInspector.ActionDelegate",
+                bindings: [
+                    {
+                        shortcut: "CtrlOrMeta+O"

[pfeldman, 2014/02/21 16:29:16]

nonmac:"ctrl+o",
mac:"cmd+o"

[apavlov, 2014/02/24 09:57:57]

CtrlOrMeta is a shortcut to this :) Fine with separating in a strict manner.

[pfeldman, 2014/03/13 05:24:02]

It is not clear what this means and it would be hard for user to configure it.
You should keep in mind that we'd want them configurable.

[apavlov, 2014/03/17 13:40:59]

Yep, split these into "mac" and "win,linux" configurations.

+                    },
+                    {
+                        shortcut: "CtrlOrMeta+P"
+                    },
+                ],
+                className: "WebInspector.SourcesPanel.ShowGoToSourceDialogActionDelegate"
             }
         ],
         scripts: [ "SourcesPanel.js" ]
     },
     {
         name: "timeline",
         extensions: [
             {
                 type: "@WebInspector.Panel",
                 name: "timeline",
@@ skipping 66 matching lines @@
             {
                 type: "@WebInspector.Drawer.ViewFactory",
                 name: "console",
                 title: "Console",
                 order: "0",
                 className: "WebInspector.ConsolePanel.ViewFactory"
             }
         ]
     },
     {
+        name: "settings",
+        extensions: [
+            {
+                type: "@WebInspector.ActionDelegate",
+                bindings: [
+                    {
+                        shortcut: "F1"
+                    },
+                    {
+                        shortcut: "?"
+                    }
+                ],
+                className: "WebInspector.SettingsController.SettingsScreenActionDelegate"
+            }
+        ]
+    },
+    {
+        name: "extensions",
         extensions: [
             {
                 type: "@WebInspector.ExtensionServerAPI",
                 className: "WebInspector.ExtensionServer"
             }
         ],
-        name: "extensions",
         scripts: [ "ExtensionServer.js" ]
     },
     {
         name: "layers",
         extensions: [
             {
                 type: "@WebInspector.Panel",
                 name: "layers",
                 title: "Layers",
                 order: 7,
@@ skipping 19 matching lines @@
                 type: "@WebInspector.SourcesPanel.EditorAction",
                 className: "WebInspector.InplaceFormatterEditorAction"
             },
             {
                 type: "@WebInspector.SourcesPanel.EditorAction",
                 className: "WebInspector.ScriptFormatterEditorAction"
             }
         ]
     }
 ];