Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 1702713003: Don't set DynamicElementImpl as staticElement for unresolved types. (Closed)

Created:
4 years, 10 months ago by scheglov
Modified:
4 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't set DynamicElementImpl as staticElement for unresolved types. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/22b9e79090e6ee6faa56a3a4bcf4131e46aaa17f

Patch Set 1 #

Total comments: 2

Patch Set 2 : Document _setElement. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -13 lines) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 1 3 chunks +19 lines, -12 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 3 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 10 months ago (2016-02-16 19:19:03 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/1702713003/diff/1/pkg/analyzer/lib/src/generated/resolver.dart File pkg/analyzer/lib/src/generated/resolver.dart (right): https://codereview.chromium.org/1702713003/diff/1/pkg/analyzer/lib/src/generated/resolver.dart#newcode12137 pkg/analyzer/lib/src/generated/resolver.dart:12137: void _setElement(Identifier typeName, Element element) { It's kind ...
4 years, 10 months ago (2016-02-16 19:32:19 UTC) #2
scheglov
https://codereview.chromium.org/1702713003/diff/1/pkg/analyzer/lib/src/generated/resolver.dart File pkg/analyzer/lib/src/generated/resolver.dart (right): https://codereview.chromium.org/1702713003/diff/1/pkg/analyzer/lib/src/generated/resolver.dart#newcode12137 pkg/analyzer/lib/src/generated/resolver.dart:12137: void _setElement(Identifier typeName, Element element) { On 2016/02/16 19:32:18, ...
4 years, 10 months ago (2016-02-16 19:56:13 UTC) #3
scheglov
4 years, 10 months ago (2016-02-16 19:58:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
22b9e79090e6ee6faa56a3a4bcf4131e46aaa17f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698