Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 1702683002: Image filters: change applyCropRect() to take a src rect. (Closed)

Created:
4 years, 10 months ago by Stephen White
Modified:
4 years, 10 months ago
Reviewers:
robertphillips, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Image filters: change applyCropRect() to take a src rect. Instead of taking the source bitmap and offset, we simply take the source rect bounds, and make the caller responsible for computing it. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1702683002 Committed: https://skia.googlesource.com/skia/+/afec27f13b28d900232cb1825c63cab2d6e4e103

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -41 lines) Patch
M include/core/SkImageFilter.h View 1 chunk +18 lines, -19 lines 0 comments Download
M src/core/SkImageFilter.cpp View 1 chunk +3 lines, -10 lines 0 comments Download
M src/effects/SkBlurImageFilter.cpp View 2 chunks +8 lines, -4 lines 0 comments Download
M src/effects/SkColorFilterImageFilter.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 2 chunks +6 lines, -2 lines 0 comments Download
M src/effects/SkDropShadowImageFilter.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M src/effects/SkOffsetImageFilter.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M src/effects/SkPaintImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkXfermodeImageFilter.cpp View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Stephen White
reed@: PTAL. Thanks!
4 years, 10 months ago (2016-02-16 16:41:17 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1702683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1702683002/1
4 years, 10 months ago (2016-02-16 16:42:10 UTC) #6
reed1
api lgtm, adding robert to see that it jives with his special work
4 years, 10 months ago (2016-02-16 16:44:10 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-16 17:05:50 UTC) #10
robertphillips
lgtm
4 years, 10 months ago (2016-02-16 17:09:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1702683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1702683002/1
4 years, 10 months ago (2016-02-16 17:10:46 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 17:11:21 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/afec27f13b28d900232cb1825c63cab2d6e4e103

Powered by Google App Engine
This is Rietveld 408576698