Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1151)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/PromiseTracker.cpp

Issue 1702673002: DevTools: migrate remote debugging protocol generators to jinja2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/PromiseTracker.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/PromiseTracker.cpp b/third_party/WebKit/Source/platform/v8_inspector/PromiseTracker.cpp
index 8b732cb3dd4b3913e2007d211cced3707d13c483..8253469870ebef7372cc41f565efa00b65cad4cf 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/PromiseTracker.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/PromiseTracker.cpp
@@ -9,9 +9,7 @@
#include "wtf/CurrentTime.h"
#include "wtf/PassOwnPtr.h"
-using blink::protocol::TypeBuilder::Array;
-using blink::protocol::TypeBuilder::Runtime::CallFrame;
-using blink::protocol::TypeBuilder::Debugger::PromiseDetails;
+using namespace blink::protocol;
namespace blink {
@@ -24,8 +22,8 @@ public:
~PromiseWrapper()
{
- RefPtr<PromiseDetails> promiseDetails = PromiseDetails::create().setId(m_id);
- m_tracker->m_agent->didUpdatePromise(protocol::Frontend::Debugger::EventType::Gc, promiseDetails.release());
+ OwnPtr<Debugger::PromiseDetails> promiseDetails = Debugger::PromiseDetails::create().setId(m_id).build();
+ m_tracker->m_agent->didUpdatePromise(Debugger::PromiseUpdated::EventTypeEnum::Gc, promiseDetails.release());
}
private:
@@ -110,21 +108,20 @@ void PromiseTracker::didReceiveV8PromiseEvent(v8::Local<v8::Context> context, v8
bool isNewPromise = false;
int id = promiseId(promise, &isNewPromise);
- protocol::Frontend::Debugger::EventType::Enum eventType = isNewPromise ? protocol::Frontend::Debugger::EventType::New : protocol::Frontend::Debugger::EventType::Update;
+ String eventType = isNewPromise ? Debugger::PromiseUpdated::EventTypeEnum::New : Debugger::PromiseUpdated::EventTypeEnum::Update;
- PromiseDetails::Status::Enum promiseStatus;
+ String promiseStatus;
switch (status) {
case 0:
- promiseStatus = PromiseDetails::Status::Pending;
+ promiseStatus = Debugger::PromiseDetails::StatusEnum::Pending;
break;
case 1:
- promiseStatus = PromiseDetails::Status::Resolved;
+ promiseStatus = Debugger::PromiseDetails::StatusEnum::Resolved;
break;
default:
- promiseStatus = PromiseDetails::Status::Rejected;
+ promiseStatus = Debugger::PromiseDetails::StatusEnum::Rejected;
};
- RefPtr<PromiseDetails> promiseDetails = PromiseDetails::create().setId(id);
- promiseDetails->setStatus(promiseStatus);
+ OwnPtr<Debugger::PromiseDetails> promiseDetails = Debugger::PromiseDetails::create().setId(id).setStatus(promiseStatus).build();
if (!parentPromise.IsEmpty() && parentPromise->IsObject()) {
v8::Local<v8::Object> handle = parentPromise->ToObject(context->GetIsolate());

Powered by Google App Engine
This is Rietveld 408576698