Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1146)

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/protocol.gyp

Issue 1702673002: DevTools: migrate remote debugging protocol generators to jinja2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/inspector_protocol/protocol.gyp
diff --git a/third_party/WebKit/Source/platform/inspector_protocol/protocol.gyp b/third_party/WebKit/Source/platform/inspector_protocol/protocol.gyp
index c5b8a883a542574feee207e7f33b18432cfc928a..b411c86478083c01eb60c630fb195aef8e028207 100644
--- a/third_party/WebKit/Source/platform/inspector_protocol/protocol.gyp
+++ b/third_party/WebKit/Source/platform/inspector_protocol/protocol.gyp
@@ -5,6 +5,11 @@
{
'variables': {
'blink_platform_output_dir': '<(SHARED_INTERMEDIATE_DIR)/blink/platform',
+ 'jinja_module_files': [
+ # jinja2/__init__.py contains version string, so sufficient for package
+ '<(DEPTH)/third_party/jinja2/__init__.py',
+ '<(DEPTH)/third_party/markupsafe/__init__.py', # jinja2 dep
+ ],
},
'targets': [
@@ -19,12 +24,17 @@
{
'action_name': 'generateInspectorProtocolBackendSources',
'inputs': [
+ '<@(jinja_module_files)',
# The python script in action below.
'CodeGenerator.py',
- # The helper script imported by CodeGenerator.py.
- 'CodeGeneratorStrings.py',
- # Input file for the script.
+ # Input files for the script.
'../../devtools/protocol.json',
+ 'Dispatcher_h.template',
+ 'Dispatcher_cpp.template',
+ 'Frontend_h.template',
+ 'Frontend_cpp.template',
+ 'TypeBuilder_h.template',
+ 'TypeBuilder_cpp.template',
],
'outputs': [
'<(blink_platform_output_dir)/inspector_protocol/Dispatcher.cpp',
@@ -34,10 +44,6 @@
'<(blink_platform_output_dir)/inspector_protocol/TypeBuilder.cpp',
'<(blink_platform_output_dir)/inspector_protocol/TypeBuilder.h',
],
- 'variables': {
- 'generator_include_dirs': [
- ],
- },
'action': [
'python',
'CodeGenerator.py',

Powered by Google App Engine
This is Rietveld 408576698