third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h - Issue 1702673002: DevTools: migrate remote debugging protocol generators to jinja2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h

Issue 1702673002: DevTools: migrate remote debugging protocol generators to jinja2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp ('K') | « third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp » ('j') | third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h

index aeb55b105c1d7d6172bf4d30997b06edb0ed0819..cd1f94d2eedea1d673ee0349eb4d5e9012340726 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h

@@ -35,7 +35,7 @@ public:

private:

friend class V8StackTraceImpl;

- PassRefPtr<protocol::TypeBuilder::Runtime::CallFrame> buildInspectorObject() const;

+ PassOwnPtr<protocol::TypeBuilder::Runtime::CallFrame> buildInspectorObject() const;

void toTracedValue(TracedValue*) const;

String m_functionName;

@@ -58,7 +58,7 @@ public:

int topColumnNumber() const override;

String topScriptId() const override;

String topFunctionName() const override;

- PassRefPtr<protocol::TypeBuilder::Runtime::StackTrace> buildInspectorObject() const override;

+ PassOwnPtr<protocol::TypeBuilder::Runtime::StackTrace> buildInspectorObject() const override;

String toString() const override;

private: