Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1125)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h

Issue 1702673002: DevTools: migrate remote debugging protocol generators to jinja2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h b/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h
index 5cb37c1311c8ab771311c676f7ca9a106f7caadc..e55a2abe4eb848ee6a13b188f586809da82e1b40 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h
@@ -60,9 +60,9 @@ public:
bool includeCommandLineAPI,
bool returnByValue,
bool generatePreview,
- RefPtr<protocol::TypeBuilder::Runtime::RemoteObject>* result,
- protocol::TypeBuilder::OptOutput<bool>* wasThrown,
- RefPtr<protocol::TypeBuilder::Runtime::ExceptionDetails>*);
+ OwnPtr<protocol::TypeBuilder::Runtime::RemoteObject>* result,
+ protocol::TypeBuilder::OptionalValue<bool>* wasThrown,
+ OwnPtr<protocol::TypeBuilder::Runtime::ExceptionDetails>*);
void callFunctionOn(
ErrorString*,
const String& objectId,
@@ -70,8 +70,8 @@ public:
const String& arguments,
bool returnByValue,
bool generatePreview,
- RefPtr<protocol::TypeBuilder::Runtime::RemoteObject>* result,
- protocol::TypeBuilder::OptOutput<bool>* wasThrown);
+ OwnPtr<protocol::TypeBuilder::Runtime::RemoteObject>* result,
+ protocol::TypeBuilder::OptionalValue<bool>* wasThrown);
void evaluateOnCallFrame(
ErrorString*,
v8::Local<v8::Object> callFrames,
@@ -82,24 +82,24 @@ public:
bool includeCommandLineAPI,
bool returnByValue,
bool generatePreview,
- RefPtr<protocol::TypeBuilder::Runtime::RemoteObject>* result,
- protocol::TypeBuilder::OptOutput<bool>* wasThrown,
- RefPtr<protocol::TypeBuilder::Runtime::ExceptionDetails>*);
+ OwnPtr<protocol::TypeBuilder::Runtime::RemoteObject>* result,
+ protocol::TypeBuilder::OptionalValue<bool>* wasThrown,
+ OwnPtr<protocol::TypeBuilder::Runtime::ExceptionDetails>*);
void restartFrame(ErrorString*, v8::Local<v8::Object> callFrames, const String& callFrameId);
- void getStepInPositions(ErrorString*, v8::Local<v8::Object> callFrames, const String& callFrameId, RefPtr<protocol::TypeBuilder::Array<protocol::TypeBuilder::Debugger::Location>>& positions);
- void setVariableValue(ErrorString*, v8::Local<v8::Object> callFrames, const String* callFrameIdOpt, const String* functionObjectIdOpt, int scopeNumber, const String& variableName, const String& newValueStr);
- void getFunctionDetails(ErrorString*, const String& functionId, RefPtr<protocol::TypeBuilder::Debugger::FunctionDetails>* result);
- void getGeneratorObjectDetails(ErrorString*, const String& functionId, RefPtr<protocol::TypeBuilder::Debugger::GeneratorObjectDetails>* result);
- void getCollectionEntries(ErrorString*, const String& objectId, RefPtr<protocol::TypeBuilder::Array<protocol::TypeBuilder::Debugger::CollectionEntry>>* result);
- void getProperties(ErrorString*, const String& objectId, bool ownProperties, bool accessorPropertiesOnly, bool generatePreview, RefPtr<protocol::TypeBuilder::Array<protocol::TypeBuilder::Runtime::PropertyDescriptor>>* result, RefPtr<protocol::TypeBuilder::Runtime::ExceptionDetails>*);
- void getInternalProperties(ErrorString*, const String& objectId, RefPtr<protocol::TypeBuilder::Array<protocol::TypeBuilder::Runtime::InternalPropertyDescriptor>>* result, RefPtr<protocol::TypeBuilder::Runtime::ExceptionDetails>*);
+ void getStepInPositions(ErrorString*, v8::Local<v8::Object> callFrames, const String& callFrameId, OwnPtr<protocol::TypeBuilder::Array<protocol::TypeBuilder::Debugger::Location>>* positions);
+ void setVariableValue(ErrorString*, v8::Local<v8::Object> callFrames, const protocol::TypeBuilder::OptionalValue<String>& callFrameIdOpt, const protocol::TypeBuilder::OptionalValue<String>& functionObjectIdOpt, int scopeNumber, const String& variableName, const String& newValueStr);
+ void getFunctionDetails(ErrorString*, const String& functionId, OwnPtr<protocol::TypeBuilder::Debugger::FunctionDetails>* result);
+ void getGeneratorObjectDetails(ErrorString*, const String& functionId, OwnPtr<protocol::TypeBuilder::Debugger::GeneratorObjectDetails>* result);
+ void getCollectionEntries(ErrorString*, const String& objectId, OwnPtr<protocol::TypeBuilder::Array<protocol::TypeBuilder::Debugger::CollectionEntry>>* result);
+ void getProperties(ErrorString*, const String& objectId, bool ownProperties, bool accessorPropertiesOnly, bool generatePreview, OwnPtr<protocol::TypeBuilder::Array<protocol::TypeBuilder::Runtime::PropertyDescriptor>>* result, OwnPtr<protocol::TypeBuilder::Runtime::ExceptionDetails>*);
+ void getInternalProperties(ErrorString*, const String& objectId, OwnPtr<protocol::TypeBuilder::Array<protocol::TypeBuilder::Runtime::InternalPropertyDescriptor>>* result, OwnPtr<protocol::TypeBuilder::Runtime::ExceptionDetails>*);
void releaseObject(const String& objectId);
v8::MaybeLocal<v8::Value> runCompiledScript(v8::Local<v8::Script>, bool includeCommandLineAPI);
- PassRefPtr<protocol::TypeBuilder::Array<protocol::TypeBuilder::Debugger::CallFrame>> wrapCallFrames(v8::Local<v8::Object>, int asyncOrdinal);
+ PassOwnPtr<protocol::TypeBuilder::Array<protocol::TypeBuilder::Debugger::CallFrame>> wrapCallFrames(v8::Local<v8::Object>, int asyncOrdinal);
- PassRefPtr<protocol::TypeBuilder::Runtime::RemoteObject> wrapObject(v8::Local<v8::Value>, const String& groupName, bool generatePreview = false) const;
- PassRefPtr<protocol::TypeBuilder::Runtime::RemoteObject> wrapTable(v8::Local<v8::Value> table, v8::Local<v8::Value> columns) const;
+ PassOwnPtr<protocol::TypeBuilder::Runtime::RemoteObject> wrapObject(v8::Local<v8::Value>, const String& groupName, bool generatePreview = false) const;
+ PassOwnPtr<protocol::TypeBuilder::Runtime::RemoteObject> wrapTable(v8::Local<v8::Value> table, v8::Local<v8::Value> columns) const;
v8::Local<v8::Value> findObject(const RemoteObjectId&) const;
String objectGroupName(const RemoteObjectId&) const;
void releaseObjectGroup(const String&);
@@ -121,8 +121,8 @@ private:
v8::Local<v8::Value> v8Value() const;
v8::Local<v8::Value> callFunctionWithEvalEnabled(V8FunctionCall&, bool& hadException) const;
void makeCall(V8FunctionCall&, RefPtr<JSONValue>* result);
- void makeEvalCall(ErrorString*, V8FunctionCall&, RefPtr<protocol::TypeBuilder::Runtime::RemoteObject>* result, protocol::TypeBuilder::OptOutput<bool>* wasThrown, RefPtr<protocol::TypeBuilder::Runtime::ExceptionDetails>* = 0);
- void makeCallWithExceptionDetails(V8FunctionCall&, RefPtr<JSONValue>* result, RefPtr<protocol::TypeBuilder::Runtime::ExceptionDetails>*);
+ void makeEvalCall(ErrorString*, V8FunctionCall&, OwnPtr<protocol::TypeBuilder::Runtime::RemoteObject>* result, protocol::TypeBuilder::OptionalValue<bool>* wasThrown, OwnPtr<protocol::TypeBuilder::Runtime::ExceptionDetails>* = 0);
+ void makeCallWithExceptionDetails(V8FunctionCall&, RefPtr<JSONValue>* result, OwnPtr<protocol::TypeBuilder::Runtime::ExceptionDetails>*);
InjectedScriptManager* m_manager;
v8::Isolate* m_isolate;

Powered by Google App Engine
This is Rietveld 408576698